chore(global): test global transaction id

Author: ehdsouza

test/test_api_exception.py

@@ -20,7 +20,6 @@ def test_api_exception():
     responses.add(responses.GET,
                   'https://test-again.com',
                   status=500,
-                  headers={'global_transaction_id': 'xx'},
                   body=json.dumps({
                       "errors": [
                           {
@@ -53,8 +52,9 @@ def test_api_exception():
     responses.add(responses.GET,
                   'https://test-for-text.com',
                   status=500,
+                  headers={'X-Global-Transaction-ID': 'xx'},
                   body="plain text error")
     mock_response = requests.get('https://test-for-text.com')
     exception = ApiException(500, http_response=mock_response)
     assert exception.message == 'plain text error'
-    assert exception.__str__() == 'Error: plain text error, Code: 500'
+    assert exception.__str__() == 'Error: plain text error, Code: 500 , X-global-transaction-id: xx'

test/test_base_service.py

@@ -235,6 +235,10 @@ def test_has_bad_first_or_last_char():
         AnyServiceV1('2018-11-20', username='{username}', password='password')
     assert str(err.value) == 'The username shouldn\'t start or end with curly brackets or quotes. Be sure to remove any {} and \" characters surrounding your username'
 
+    with pytest.raises(ValueError) as err:
+        AnyServiceV1('2018-11-20', username='username', password='{password}')
+    assert str(err.value) == 'The password shouldn\'t start or end with curly brackets or quotes. Be sure to remove any {} and \" characters surrounding your password'
+
     with pytest.raises(ValueError) as err:
         AnyServiceV1('2018-11-20', iam_apikey='{apikey}')
     assert str(err.value) == 'The credentials shouldn\'t start or end with curly brackets or quotes. Be sure to remove any {} and \" characters surrounding your credentials'
@@ -243,6 +247,16 @@ def test_has_bad_first_or_last_char():
         AnyServiceV1('2018-11-20', iam_apikey='apikey', url='"url"')
     assert str(err.value) == 'The URL shouldn\'t start or end with curly brackets or quotes. Be sure to remove any {} and \" characters surrounding your URL'
 
+    with pytest.raises(ValueError) as err:
+        service = AnyServiceV1('2018-11-20', iam_apikey='apikey', url='url')
+        service.set_iam_apikey('"wrong"')
+    assert str(err.value) == 'The credentials shouldn\'t start or end with curly brackets or quotes. Be sure to remove any {} and \" characters surrounding your credentials'
+
+    with pytest.raises(ValueError) as err:
+        service = AnyServiceV1('2018-11-20', iam_apikey='apikey', url='url')
+        service.set_url('"wrong"')
+    assert str(err.value) == 'The URL shouldn\'t start or end with curly brackets or quotes. Be sure to remove any {} and \" characters surrounding your URL'
+
 def test_set_credential_based_on_type():
     file_path = os.path.join(os.path.dirname(__file__), '../resources/ibm-credentials.env')
     os.environ['IBM_CREDENTIALS_FILE'] = file_path

test/test_detailed_response.py

@@ -21,3 +21,4 @@ def test_detailed_response():
 
     dict_repr = detailed_response._to_dict()
     assert dict_repr['result'] == {'foobar': 'baz'}
+    detailed_response.__str__()