Skip to content

Commit fbdf3d4

Browse files
committed
fix(classname): Classname is no longer needed param
1 parent a7f10ac commit fbdf3d4

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

ibm_cloud_sdk_core/base_service.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,9 @@ def prepare_request(self, method, url, headers=None,
205205

206206

207207
@staticmethod
208-
def _convert_model(val, classname=None):
209-
if classname is not None:
210-
if isinstance(val, str):
211-
val = json_import.loads(val)
208+
def _convert_model(val):
209+
if isinstance(val, str):
210+
val = json_import.loads(val)
212211
if hasattr(val, "_to_dict"):
213212
return val._to_dict()
214213
return val

test/test_base_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ def _from_dict(cls, _dict):
343343
model1 = service._convert_model(mock)
344344
assert model1 == {'x': 'foo'}
345345

346-
model2 = service._convert_model("{\"x\": \"foo\"}", MockModel)
346+
model2 = service._convert_model("{\"x\": \"foo\"}")
347347
assert model2 is not None
348348
assert model2['x'] == 'foo'
349349

0 commit comments

Comments
 (0)