chore(build): use node 14 for new semantic-release #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 22 22
Lines 815 815
=======================================
Hits 811 811
Misses 4 4 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps us up to node v14 to accommodate the new semantic-release v18
For some reason, my initial change to bump node to v14 resulted in some additional lint warnings related to the use f-strings and failed the build. I added another change to disable that lint check as a bit of research revealed that it's a dubious check to perform anyhow :)