feat: add authentication_type method to authenticators #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 99.50% 99.52% +0.01%
==========================================
Files 22 22
Lines 815 835 +20
==========================================
+ Hits 811 831 +20
Misses 4 4
Continue to review full report at Codecov.
|
This commit adds a new method ('authentication_type()') to
the Authenticator base class, and each authenticator implementation
(subclasses of Authenticator).
The function will return a string indicating the
authenticator type ('basic', 'iam', etc.).
This brings the python core in line with the Go, Java and Node cores.
padamstx
force-pushed
the
update-authenticators
branch
from
cbbcc1f to
c45f65a
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Oct 15, 2021
# [3.12.0](v3.11.3...v3.12.0) (2021-10-15) ### Features * add authentication_type method to authenticators ([#127](#127)) ([c56ce73](c56ce73))
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new method ('authentication_type()') to
the Authenticator base class, and each authenticator implementation
(subclasses of Authenticator).
The function will return a string indicating the
authenticator type ('basic', 'iam', etc.).
This brings the python core in line with the Go, Java and Node cores.