fix: improve the detection and loading of default certificates #197
Conversation
pyrooka
requested review from
padamstx and
ricellis
and removed request for
padamstx
Signed-off-by: Norbert Biczo <[email protected]>
pyrooka
force-pushed
the
nb/load-certifi-certs
branch
from
45b8bf0 to
2ff9c70
Compare
There was a problem hiding this comment.
My only comment would be whether certifi should be added to the requirements.txt since it is now referenced directly, but is included transitively via requests. I suppose another option might be using requests.certs.where() to avoid the reference to certifi. I suppose another advantage of that might be that anyone using a custom requests package would get their expected behaviour - see e.g. https://github.com/psf/requests/blob/main/src/requests/certs.py
|
That's a really good point! About the requirements, I did not add the |
Signed-off-by: Norbert Biczo <[email protected]>
pyrooka
force-pushed
the
nb/load-certifi-certs
branch
from
592065f to
d21f2ce
Compare
## [3.20.3](v3.20.2...v3.20.3) (2024-07-11) ### Bug Fixes * improve the detection and loading of default certificates ([#197](#197)) ([3dc4cc4](3dc4cc4))
|
🎉 This PR is included in version 3.20.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Follow up PR of #196. Turned out in some cases - especially in containers - the certificate verification is still failing due to the missing certs. It's because the location of those files really depend on the system and the OpenSSL configuration.
This PR adds a workaround for this problem, by loading the default certs from the location that the
certifipackage reports. Therequestspackage uses the same logic, so it should cause no issues.