Skip to content

feat: Add date_to_string and string_to_date utility methods #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

mkistler
Copy link
Contributor

This PR adds utility methods to serialize and deserialize date values.

@mkistler mkistler requested a review from padamstx December 19, 2019 15:39
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #52 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   97.75%   97.77%   +0.01%     
==========================================
  Files          17       17              
  Lines         579      584       +5     
==========================================
+ Hits          566      571       +5     
  Misses         13       13
Impacted Files Coverage Δ
ibm_cloud_sdk_core/utils.py 99.09% <100%> (+0.03%) ⬆️
ibm_cloud_sdk_core/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b76c78...6dbfff9. Read the comment docs.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for adding the tests :)

@mkistler mkistler merged commit d4d9c38 into master Dec 19, 2019
@mkistler mkistler deleted the mdk/date-utils branch December 19, 2019 18:15
@ibm-devx-automation
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants