Handle conversions for naive datetime values #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
datetime_to_string
andstring_to_datetime
handling of dates without timezone information.Python datetime values come in two forms: "naive" and "aware"
https://docs.python.org/3/library/datetime.html#aware-and-naive-objects
The fundamental difference between these two forms is that "naive" datetimes do not have a timezone, whereas "aware" datetimes do.
This PR fixes the core utility methods for converting datetime to/from strings.