fix(Findings): createTime and updateTime in NoteOptions

Author: gary1998

ibm_scc/findings_v1.py

@@ -230,6 +230,8 @@ def create_note(self,
         reported_by: 'Reporter',
         *,
         related_url: List['ApiNoteRelatedUrl'] = None,
+        create_time: datetime = None,
+        update_time: datetime = None,
         shared: bool = None,
         finding: 'FindingType' = None,
         kpi: 'KpiType' = None,
@@ -262,6 +264,10 @@ def create_note(self,
         :param str id: The ID of the note.
         :param Reporter reported_by: The entity reporting a note.
         :param List[ApiNoteRelatedUrl] related_url: (optional)
+        :param datetime create_time: (optional) Output only. The time this note was
+               created. This field can be used as a filter in list requests.
+        :param datetime update_time: (optional) Output only. The time this note was
+               last updated. This field can be used as a filter in list requests.
         :param bool shared: (optional) True if this note can be shared by multiple
                accounts.
         :param FindingType finding: (optional) FindingType provides details about a
@@ -293,6 +299,10 @@ def create_note(self,
         reported_by = convert_model(reported_by)
         if related_url is not None:
             related_url = [convert_model(x) for x in related_url]
+        if create_time is not None:
+            create_time = datetime_to_string(create_time)
+        if update_time is not None:
+            update_time = datetime_to_string(update_time)
         if finding is not None:
             finding = convert_model(finding)
         if kpi is not None:
@@ -316,6 +326,8 @@ def create_note(self,
             'id': id,
             'reported_by': reported_by,
             'related_url': related_url,
+            'create_time': create_time,
+            'update_time': update_time,
             'shared': shared,
             'finding': finding,
             'kpi': kpi,
@@ -462,6 +474,8 @@ def update_note(self,
         reported_by: 'Reporter',
         *,
         related_url: List['ApiNoteRelatedUrl'] = None,
+        create_time: datetime = None,
+        update_time: datetime = None,
         shared: bool = None,
         finding: 'FindingType' = None,
         kpi: 'KpiType' = None,
@@ -493,6 +507,10 @@ def update_note(self,
         :param str id: The ID of the note.
         :param Reporter reported_by: The entity reporting a note.
         :param List[ApiNoteRelatedUrl] related_url: (optional)
+        :param datetime create_time: (optional) Output only. The time this note was
+               created. This field can be used as a filter in list requests.
+        :param datetime update_time: (optional) Output only. The time this note was
+               last updated. This field can be used as a filter in list requests.
         :param bool shared: (optional) True if this note can be shared by multiple
                accounts.
         :param FindingType finding: (optional) FindingType provides details about a
@@ -526,6 +544,10 @@ def update_note(self,
         reported_by = convert_model(reported_by)
         if related_url is not None:
             related_url = [convert_model(x) for x in related_url]
+        if create_time is not None:
+            create_time = datetime_to_string(create_time)
+        if update_time is not None:
+            update_time = datetime_to_string(update_time)
         if finding is not None:
             finding = convert_model(finding)
         if kpi is not None:
@@ -549,6 +571,8 @@ def update_note(self,
             'id': id,
             'reported_by': reported_by,
             'related_url': related_url,
+            'create_time': create_time,
+            'update_time': update_time,
             'shared': shared,
             'finding': finding,
             'kpi': kpi,
@@ -2682,6 +2706,10 @@ def __init__(self,
         :param str id: The ID of the note.
         :param Reporter reported_by: The entity reporting a note.
         :param List[ApiNoteRelatedUrl] related_url: (optional)
+        :param datetime create_time: (optional) Output only. The time this note was
+               created. This field can be used as a filter in list requests.
+        :param datetime update_time: (optional) Output only. The time this note was
+               last updated. This field can be used as a filter in list requests.
         :param bool shared: (optional) True if this note can be shared by multiple
                accounts.
         :param FindingType finding: (optional) FindingType provides details about a
@@ -2764,10 +2792,10 @@ def to_dict(self) -> Dict:
             _dict['kind'] = self.kind
         if hasattr(self, 'related_url') and self.related_url is not None:
             _dict['related_url'] = [x.to_dict() for x in self.related_url]
-        if hasattr(self, 'create_time') and getattr(self, 'create_time') is not None:
-            _dict['create_time'] = datetime_to_string(getattr(self, 'create_time'))
-        if hasattr(self, 'update_time') and getattr(self, 'update_time') is not None:
-            _dict['update_time'] = datetime_to_string(getattr(self, 'update_time'))
+        if hasattr(self, 'create_time') and self.create_time is not None:
+            _dict['create_time'] = datetime_to_string(self.create_time)
+        if hasattr(self, 'update_time') and self.update_time is not None:
+            _dict['update_time'] = datetime_to_string(self.update_time)
         if hasattr(self, 'id') and self.id is not None:
             _dict['id'] = self.id
         if hasattr(self, 'shared') and self.shared is not None:

test/unit/test_findings_v1.py

@@ -487,6 +487,8 @@ def test_create_note_all_params(self):
         id = 'testString'
         reported_by = reporter_model
         related_url = [api_note_related_url_model]
+        create_time = string_to_datetime('2019-01-01T12:00:00.000Z')
+        update_time = string_to_datetime('2019-01-01T12:00:00.000Z')
         shared = True
         finding = finding_type_model
         kpi = kpi_type_model
@@ -503,6 +505,8 @@ def test_create_note_all_params(self):
             id,
             reported_by,
             related_url=related_url,
+            create_time=create_time,
+            update_time=update_time,
             shared=shared,
             finding=finding,
             kpi=kpi,
@@ -523,6 +527,8 @@ def test_create_note_all_params(self):
         assert req_body['id'] == 'testString'
         assert req_body['reported_by'] == reporter_model
         assert req_body['related_url'] == [api_note_related_url_model]
+        assert req_body['create_time'] == "2019-01-01T12:00:00Z"
+        assert req_body['update_time'] == "2019-01-01T12:00:00Z"
         assert req_body['shared'] == True
         assert req_body['finding'] == finding_type_model
         assert req_body['kpi'] == kpi_type_model
@@ -617,6 +623,8 @@ def test_create_note_required_params(self):
         id = 'testString'
         reported_by = reporter_model
         related_url = [api_note_related_url_model]
+        create_time = string_to_datetime('2019-01-01T12:00:00.000Z')
+        update_time = string_to_datetime('2019-01-01T12:00:00.000Z')
         shared = True
         finding = finding_type_model
         kpi = kpi_type_model
@@ -632,6 +640,8 @@ def test_create_note_required_params(self):
             id,
             reported_by,
             related_url=related_url,
+            create_time=create_time,
+            update_time=update_time,
             shared=shared,
             finding=finding,
             kpi=kpi,
@@ -651,6 +661,8 @@ def test_create_note_required_params(self):
         assert req_body['id'] == 'testString'
         assert req_body['reported_by'] == reporter_model
         assert req_body['related_url'] == [api_note_related_url_model]
+        assert req_body['create_time'] == "2019-01-01T12:00:00Z"
+        assert req_body['update_time'] == "2019-01-01T12:00:00Z"
         assert req_body['shared'] == True
         assert req_body['finding'] == finding_type_model
         assert req_body['kpi'] == kpi_type_model
@@ -745,6 +757,8 @@ def test_create_note_value_error(self):
         id = 'testString'
         reported_by = reporter_model
         related_url = [api_note_related_url_model]
+        create_time = string_to_datetime('2019-01-01T12:00:00.000Z')
+        update_time = string_to_datetime('2019-01-01T12:00:00.000Z')
         shared = True
         finding = finding_type_model
         kpi = kpi_type_model
@@ -1138,6 +1152,8 @@ def test_update_note_all_params(self):
         id = 'testString'
         reported_by = reporter_model
         related_url = [api_note_related_url_model]
+        create_time = string_to_datetime('2019-01-01T12:00:00.000Z')
+        update_time = string_to_datetime('2019-01-01T12:00:00.000Z')
         shared = True
         finding = finding_type_model
         kpi = kpi_type_model
@@ -1155,6 +1171,8 @@ def test_update_note_all_params(self):
             id,
             reported_by,
             related_url=related_url,
+            create_time=create_time,
+            update_time=update_time,
             shared=shared,
             finding=finding,
             kpi=kpi,
@@ -1175,6 +1193,8 @@ def test_update_note_all_params(self):
         assert req_body['id'] == 'testString'
         assert req_body['reported_by'] == reporter_model
         assert req_body['related_url'] == [api_note_related_url_model]
+        assert req_body['create_time'] == "2019-01-01T12:00:00Z"
+        assert req_body['update_time'] == "2019-01-01T12:00:00Z"
         assert req_body['shared'] == True
         assert req_body['finding'] == finding_type_model
         assert req_body['kpi'] == kpi_type_model
@@ -1270,6 +1290,8 @@ def test_update_note_required_params(self):
         id = 'testString'
         reported_by = reporter_model
         related_url = [api_note_related_url_model]
+        create_time = string_to_datetime('2019-01-01T12:00:00.000Z')
+        update_time = string_to_datetime('2019-01-01T12:00:00.000Z')
         shared = True
         finding = finding_type_model
         kpi = kpi_type_model
@@ -1286,6 +1308,8 @@ def test_update_note_required_params(self):
             id,
             reported_by,
             related_url=related_url,
+            create_time=create_time,
+            update_time=update_time,
             shared=shared,
             finding=finding,
             kpi=kpi,
@@ -1305,6 +1329,8 @@ def test_update_note_required_params(self):
         assert req_body['id'] == 'testString'
         assert req_body['reported_by'] == reporter_model
         assert req_body['related_url'] == [api_note_related_url_model]
+        assert req_body['create_time'] == "2019-01-01T12:00:00Z"
+        assert req_body['update_time'] == "2019-01-01T12:00:00Z"
         assert req_body['shared'] == True
         assert req_body['finding'] == finding_type_model
         assert req_body['kpi'] == kpi_type_model
@@ -1400,6 +1426,8 @@ def test_update_note_value_error(self):
         id = 'testString'
         reported_by = reporter_model
         related_url = [api_note_related_url_model]
+        create_time = string_to_datetime('2019-01-01T12:00:00.000Z')
+        update_time = string_to_datetime('2019-01-01T12:00:00.000Z')
         shared = True
         finding = finding_type_model
         kpi = kpi_type_model