Skip to content

Commit e4fa001

Browse files
committed
fix(FindingsAPI): deprecated
BREAKING CHANGE: deprecating Security Insights
1 parent 7e08c54 commit e4fa001

File tree

9 files changed

+3
-9054
lines changed

9 files changed

+3
-9054
lines changed

.github/workflows/main.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
if: "!startsWith(github.event.head_commit.message, 'chore') && !startsWith(github.ref, 'refs/tags/v')"
88
strategy:
99
matrix:
10-
python-version: [3.6, 3.7, 3.8, 3.9]
10+
python-version: [3.7, 3.8, 3.9]
1111
steps:
1212
- uses: actions/checkout@v1
1313

@@ -28,7 +28,7 @@ jobs:
2828
strategy:
2929
max-parallel: 2
3030
matrix:
31-
python-version: [3.6, 3.7, 3.8, 3.9]
31+
python-version: [3.7, 3.8, 3.9]
3232
steps:
3333
- name: setup extensions
3434
uses: actions/checkout@v1
@@ -56,7 +56,6 @@ jobs:
5656
- name: running integration tests
5757
env:
5858
ACCOUNT_ID: ${{ secrets.ACCOUNT_ID }}
59-
FINDINGS_ENV: ${{ secrets.FINDINGS_ENV }}
6059
CONFIGURATION_GOVERNANCE_ENV: ${{ secrets.CONFIGURATION_GOVERNANCE_ENV }}
6160
RESOURCE_GROUP_ID: ${{ secrets.RESOURCE_GROUP_ID }}
6261
run: build/testScript.sh

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ IBM Cloud services:
4747

4848
Service Name | Module Name | Imported Class Name
4949
--- | --- | ---
50-
[Findings](https://cloud.ibm.com/apidocs/security-compliance/findings) | findings_v1 | FindingsV1
5150
[Configuration Governance](https://cloud.ibm.com/apidocs/security-compliance/config) | configuration_governance_v1 | ConfigurationGovernanceV1
5251

5352
## Prerequisites
@@ -56,7 +55,7 @@ Service Name | Module Name | Imported Class Name
5655

5756
* An [IBM Cloud][ibm-cloud-onboarding] account.
5857
* An IAM API key to allow the SDK to access your account. Create one [here](https://cloud.ibm.com/iam/apikeys).
59-
* Python 3.6 or above.
58+
* Python 3.7 or above.
6059

6160
## Installation
6261

build/testScript.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@
33
set -euo pipefail
44

55
curl https://us-south.functions.appdomain.cloud/api/v1/web/e6b54af6-ab44-4149-a8e4-e906dcc58136/default/secadvstg-location-shift.json
6-
echo "${FINDINGS_ENV}" | base64 -d >> findings_v1.env
76
echo "${CONFIGURATION_GOVERNANCE_ENV}" | base64 -d >> configuration_governance_v1.env
87
python -m pytest test/integration

0 commit comments

Comments
 (0)