Skip to content

Commit 3d1751e

Browse files
raikonenfnuIanWood1
authored andcommitted
[mlir][gpu] Fix breaking constructor from GPUSubgroupSizeToROCDL (llvm#137439)
This PR addressed a bug from llvm#137360. which was using GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing compilation error below: error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly deleted Signed-off-by: Stanley Winata <[email protected]>
1 parent fddb297 commit 3d1751e

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -455,9 +455,7 @@ void mlir::populateGpuToROCDLConversionPatterns(
455455
// TODO: Add alignment for workgroup memory
456456
patterns.add<GPUDynamicSharedMemoryOpLowering>(converter);
457457

458-
patterns
459-
.add<GPUShuffleOpLowering, GPULaneIdOpToROCDL, GPUSubgroupSizeOpToROCDL>(
460-
converter);
458+
patterns.add<GPUShuffleOpLowering, GPULaneIdOpToROCDL>(converter);
461459
patterns.add<GPUSubgroupSizeOpToROCDL>(converter, chipset);
462460

463461
populateMathToROCDLConversionPatterns(converter, patterns);

0 commit comments

Comments
 (0)