Skip to content

Commit 9cbd44c

Browse files
tambryIanWood1
authored andcommitted
[lldb][Telemetry] Fix unit test compile failure with LLVM_ENABLE_TELEMETRY=0 (llvm#136115)
It needs to be `TEST_F` to access `received_entries`. Disabling also works based on the test not the fixture name. Build failure: ``` lldb/unittests/Core/TelemetryTest.cpp:110:17: error: use of undeclared identifier 'received_entries' 110 | ASSERT_EQ(1U, received_entries.size()); | ^ lldb/unittests/Core/TelemetryTest.cpp:112:61: error: use of undeclared identifier 'received_entries' 112 | llvm::dyn_cast<lldb_private::FakeTelemetryInfo>(received_entries[0]) | ^ ``` Fixes: 159b872
1 parent ec589ff commit 9cbd44c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/unittests/Core/TelemetryTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class TelemetryTest : public testing::Test {
9696
#if LLVM_ENABLE_TELEMETRY
9797
#define TELEMETRY_TEST(suite, test) TEST_F(suite, test)
9898
#else
99-
#define TELEMETRY_TEST(suite, test) TEST(DISABLED_##suite, test)
99+
#define TELEMETRY_TEST(suite, test) TEST_F(suite, DISABLED_##test)
100100
#endif
101101

102102
TELEMETRY_TEST(TelemetryTest, PluginTest) {

0 commit comments

Comments
 (0)