Skip to content

Add tests for resource fungibility plugin #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Add tests for resource fungibility plugin #21

merged 1 commit into from
Jun 5, 2025

Conversation

carlory
Copy link
Member

@carlory carlory commented Jun 3, 2025

No description provided.

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Jun 3, 2025
@InftyAI-Agent InftyAI-Agent requested review from kerthcet June 3, 2025 09:26
kerthcet
kerthcet reviewed Jun 3, 2025
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments.

pkg/plugins/resource_fungibility/resource_fungibility_test.go Outdated

state := framework.NewCycleState()
var gotStatus *framework.Status
if tc.runPreFilter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean runPreFilter, to me, every case needs to run the PreFilter, it's the entrypoint.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@kerthcet
Copy link
Member

kerthcet commented Jun 3, 2025

Also please rebase the codebase, then the lint error will disappear, I just upgrade the golangci version.

@kerthcet
Copy link
Member

kerthcet commented Jun 5, 2025

/lgtm
/approve

Thanks @carlory

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 5, 2025
@kerthcet
Copy link
Member

kerthcet commented Jun 5, 2025

/kind cleanup

@InftyAI-Agent InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Jun 5, 2025
@InftyAI-Agent InftyAI-Agent merged commit ed9168d into InftyAI:main Jun 5, 2025
29 checks passed
@carlory carlory deleted the isvc branch June 5, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlory @kerthcet @InftyAI-Agent