Skip to content

Commit 0aa5321

Browse files
ndgrigorianndgrigorian
committed
Remove unnecessary comments about std::disjunction throughout project
1 parent ab068f5 commit 0aa5321

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+124
-265
lines changed

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/abs.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,7 @@ using AbsContigFunctor =
102102

103103
template <typename T> struct AbsOutputType
104104
{
105-
using value_type = typename std::disjunction< // disjunction is C++17
106-
// feature, supported by DPC++
105+
using value_type = typename std::disjunction<
107106
td_ns::TypeMapResultEntry<T, bool>,
108107
td_ns::TypeMapResultEntry<T, std::uint8_t>,
109108
td_ns::TypeMapResultEntry<T, std::uint16_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/acos.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,7 @@ using AcosStridedFunctor = elementwise_common::
145145

146146
template <typename T> struct AcosOutputType
147147
{
148-
using value_type = typename std::disjunction< // disjunction is C++17
149-
// feature, supported by DPC++
148+
using value_type = typename std::disjunction<
150149
td_ns::TypeMapResultEntry<T, sycl::half>,
151150
td_ns::TypeMapResultEntry<T, float>,
152151
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/acosh.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,7 @@ using AcoshStridedFunctor = elementwise_common::
172172

173173
template <typename T> struct AcoshOutputType
174174
{
175-
using value_type = typename std::disjunction< // disjunction is C++17
176-
// feature, supported by DPC++
175+
using value_type = typename std::disjunction<
177176
td_ns::TypeMapResultEntry<T, sycl::half>,
178177
td_ns::TypeMapResultEntry<T, float>,
179178
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/add.hpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,7 @@ using AddStridedFunctor =
132132

133133
template <typename T1, typename T2> struct AddOutputType
134134
{
135-
using value_type = typename std::disjunction< // disjunction is C++17
136-
// feature, supported by DPC++
135+
using value_type = typename std::disjunction<
137136
td_ns::BinaryTypeMapResultEntry<T1, bool, T2, bool, bool>,
138137
td_ns::BinaryTypeMapResultEntry<T1,
139138
std::uint8_t,
@@ -442,10 +441,7 @@ class add_inplace_contig_kernel;
442441
template <typename argTy, typename resTy> struct AddInplaceTypePairSupport
443442
{
444443
/* value if true a kernel for <argTy, resTy> must be instantiated */
445-
static constexpr bool is_defined = std::disjunction< // disjunction is
446-
// C++17 feature,
447-
// supported by
448-
// DPC++ input bool
444+
static constexpr bool is_defined = std::disjunction<
449445
td_ns::TypePairDefinedEntry<argTy, bool, resTy, bool>,
450446
td_ns::TypePairDefinedEntry<argTy, std::int8_t, resTy, std::int8_t>,
451447
td_ns::TypePairDefinedEntry<argTy, std::uint8_t, resTy, std::uint8_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/angle.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ using AngleStridedFunctor = elementwise_common::
9191

9292
template <typename T> struct AngleOutputType
9393
{
94-
using value_type = typename std::disjunction< // disjunction is C++17
95-
// feature, supported by DPC++
94+
using value_type = typename std::disjunction<
9695
td_ns::TypeMapResultEntry<T, std::complex<float>, float>,
9796
td_ns::TypeMapResultEntry<T, std::complex<double>, double>,
9897
td_ns::DefaultResultEntry<void>>::result_type;

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/asin.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,7 @@ using AsinStridedFunctor = elementwise_common::
165165

166166
template <typename T> struct AsinOutputType
167167
{
168-
using value_type = typename std::disjunction< // disjunction is C++17
169-
// feature, supported by DPC++
168+
using value_type = typename std::disjunction<
170169
td_ns::TypeMapResultEntry<T, sycl::half>,
171170
td_ns::TypeMapResultEntry<T, float>,
172171
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/asinh.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,7 @@ using AsinhStridedFunctor = elementwise_common::
148148

149149
template <typename T> struct AsinhOutputType
150150
{
151-
using value_type = typename std::disjunction< // disjunction is C++17
152-
// feature, supported by DPC++
151+
using value_type = typename std::disjunction<
153152
td_ns::TypeMapResultEntry<T, sycl::half>,
154153
td_ns::TypeMapResultEntry<T, float>,
155154
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/atan.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,7 @@ using AtanStridedFunctor = elementwise_common::
155155

156156
template <typename T> struct AtanOutputType
157157
{
158-
using value_type = typename std::disjunction< // disjunction is C++17
159-
// feature, supported by DPC++
158+
using value_type = typename std::disjunction<
160159
td_ns::TypeMapResultEntry<T, sycl::half>,
161160
td_ns::TypeMapResultEntry<T, float>,
162161
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/atan2.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ using Atan2StridedFunctor =
9090

9191
template <typename T1, typename T2> struct Atan2OutputType
9292
{
93-
using value_type = typename std::disjunction< // disjunction is C++17
94-
// feature, supported by DPC++
93+
using value_type = typename std::disjunction<
9594
td_ns::BinaryTypeMapResultEntry<T1,
9695
sycl::half,
9796
T2,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/atanh.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ using AtanhStridedFunctor = elementwise_common::
149149

150150
template <typename T> struct AtanhOutputType
151151
{
152-
using value_type = typename std::disjunction< // disjunction is C++17
153-
// feature, supported by DPC++
152+
using value_type = typename std::disjunction<
154153
td_ns::TypeMapResultEntry<T, sycl::half>,
155154
td_ns::TypeMapResultEntry<T, float>,
156155
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/bitwise_and.hpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,7 @@ using BitwiseAndStridedFunctor = elementwise_common::BinaryStridedFunctor<
113113

114114
template <typename T1, typename T2> struct BitwiseAndOutputType
115115
{
116-
using value_type = typename std::disjunction< // disjunction is C++17
117-
// feature, supported by
118-
// DPC++
116+
using value_type = typename std::disjunction<
119117
td_ns::BinaryTypeMapResultEntry<T1, bool, T2, bool, bool>,
120118
td_ns::BinaryTypeMapResultEntry<T1,
121119
std::uint8_t,
@@ -327,10 +325,7 @@ template <typename argTy, typename resTy>
327325
struct BitwiseAndInplaceTypePairSupport
328326
{
329327
/* value if true a kernel for <argTy, resTy> must be instantiated */
330-
static constexpr bool is_defined = std::disjunction< // disjunction is
331-
// C++17 feature,
332-
// supported by
333-
// DPC++ input bool
328+
static constexpr bool is_defined = std::disjunction<
334329
td_ns::TypePairDefinedEntry<argTy, bool, resTy, bool>,
335330
td_ns::TypePairDefinedEntry<argTy, std::int8_t, resTy, std::int8_t>,
336331
td_ns::TypePairDefinedEntry<argTy, std::uint8_t, resTy, std::uint8_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/bitwise_invert.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,7 @@ using BitwiseInvertStridedFunctor =
100100

101101
template <typename argTy> struct BitwiseInvertOutputType
102102
{
103-
using value_type = typename std::disjunction< // disjunction is C++17
104-
// feature, supported by DPC++
103+
using value_type = typename std::disjunction<
105104
td_ns::TypeMapResultEntry<argTy, bool>,
106105
td_ns::TypeMapResultEntry<argTy, std::uint8_t>,
107106
td_ns::TypeMapResultEntry<argTy, std::uint16_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/bitwise_left_shift.hpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,7 @@ using BitwiseLeftShiftStridedFunctor = elementwise_common::BinaryStridedFunctor<
123123
template <typename T1, typename T2> struct BitwiseLeftShiftOutputType
124124
{
125125
using ResT = T1;
126-
using value_type = typename std::disjunction< // disjunction is C++17
127-
// feature, supported by
128-
// DPC++
126+
using value_type = typename std::disjunction<
129127
td_ns::BinaryTypeMapResultEntry<T1,
130128
std::int8_t,
131129
T2,
@@ -341,10 +339,7 @@ template <typename argTy, typename resTy>
341339
struct BitwiseLeftShiftInplaceTypePairSupport
342340
{
343341
/* value if true a kernel for <argTy, resTy> must be instantiated */
344-
static constexpr bool is_defined = std::disjunction< // disjunction is
345-
// C++17 feature,
346-
// supported by
347-
// DPC++ input bool
342+
static constexpr bool is_defined = std::disjunction<
348343
td_ns::TypePairDefinedEntry<argTy, std::int8_t, resTy, std::int8_t>,
349344
td_ns::TypePairDefinedEntry<argTy, std::uint8_t, resTy, std::uint8_t>,
350345
td_ns::TypePairDefinedEntry<argTy, std::int16_t, resTy, std::int16_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/bitwise_or.hpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,7 @@ using BitwiseOrStridedFunctor = elementwise_common::BinaryStridedFunctor<
112112

113113
template <typename T1, typename T2> struct BitwiseOrOutputType
114114
{
115-
using value_type = typename std::disjunction< // disjunction is C++17
116-
// feature, supported by
117-
// DPC++
115+
using value_type = typename std::disjunction<
118116
td_ns::BinaryTypeMapResultEntry<T1, bool, T2, bool, bool>,
119117
td_ns::BinaryTypeMapResultEntry<T1,
120118
std::uint8_t,
@@ -322,10 +320,7 @@ class bitwise_or_inplace_contig_kernel;
322320
template <typename argTy, typename resTy> struct BitwiseOrInplaceTypePairSupport
323321
{
324322
/* value if true a kernel for <argTy, resTy> must be instantiated */
325-
static constexpr bool is_defined = std::disjunction< // disjunction is
326-
// C++17 feature,
327-
// supported by
328-
// DPC++ input bool
323+
static constexpr bool is_defined = std::disjunction<
329324
td_ns::TypePairDefinedEntry<argTy, bool, resTy, bool>,
330325
td_ns::TypePairDefinedEntry<argTy, std::int8_t, resTy, std::int8_t>,
331326
td_ns::TypePairDefinedEntry<argTy, std::uint8_t, resTy, std::uint8_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/bitwise_right_shift.hpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,7 @@ using BitwiseRightShiftStridedFunctor =
125125
template <typename T1, typename T2> struct BitwiseRightShiftOutputType
126126
{
127127
using ResT = T1;
128-
using value_type = typename std::disjunction< // disjunction is C++17
129-
// feature, supported by
130-
// DPC++
128+
using value_type = typename std::disjunction<
131129
td_ns::BinaryTypeMapResultEntry<T1,
132130
std::int8_t,
133131
T2,
@@ -345,10 +343,7 @@ template <typename argTy, typename resTy>
345343
struct BitwiseRightShiftInplaceTypePairSupport
346344
{
347345
/* value if true a kernel for <argTy, resTy> must be instantiated */
348-
static constexpr bool is_defined = std::disjunction< // disjunction is
349-
// C++17 feature,
350-
// supported by
351-
// DPC++ input bool
346+
static constexpr bool is_defined = std::disjunction<
352347
td_ns::TypePairDefinedEntry<argTy, std::int8_t, resTy, std::int8_t>,
353348
td_ns::TypePairDefinedEntry<argTy, std::uint8_t, resTy, std::uint8_t>,
354349
td_ns::TypePairDefinedEntry<argTy, std::int16_t, resTy, std::int16_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/bitwise_xor.hpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,7 @@ using BitwiseXorStridedFunctor = elementwise_common::BinaryStridedFunctor<
113113

114114
template <typename T1, typename T2> struct BitwiseXorOutputType
115115
{
116-
using value_type = typename std::disjunction< // disjunction is C++17
117-
// feature, supported by
118-
// DPC++
116+
using value_type = typename std::disjunction<
119117
td_ns::BinaryTypeMapResultEntry<T1, bool, T2, bool, bool>,
120118
td_ns::BinaryTypeMapResultEntry<T1,
121119
std::uint8_t,
@@ -327,10 +325,7 @@ template <typename argTy, typename resTy>
327325
struct BitwiseXorInplaceTypePairSupport
328326
{
329327
/* value if true a kernel for <argTy, resTy> must be instantiated */
330-
static constexpr bool is_defined = std::disjunction< // disjunction is
331-
// C++17 feature,
332-
// supported by
333-
// DPC++ input bool
328+
static constexpr bool is_defined = std::disjunction<
334329
td_ns::TypePairDefinedEntry<argTy, bool, resTy, bool>,
335330
td_ns::TypePairDefinedEntry<argTy, std::int8_t, resTy, std::int8_t>,
336331
td_ns::TypePairDefinedEntry<argTy, std::uint8_t, resTy, std::uint8_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/cbrt.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ using CbrtStridedFunctor = elementwise_common::
8282

8383
template <typename T> struct CbrtOutputType
8484
{
85-
using value_type = typename std::disjunction< // disjunction is C++17
86-
// feature, supported by DPC++
85+
using value_type = typename std::disjunction<
8786
td_ns::TypeMapResultEntry<T, sycl::half, sycl::half>,
8887
td_ns::TypeMapResultEntry<T, float, float>,
8988
td_ns::TypeMapResultEntry<T, double, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/ceil.hpp

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -95,20 +95,19 @@ using CeilStridedFunctor = elementwise_common::
9595

9696
template <typename T> struct CeilOutputType
9797
{
98-
using value_type = typename std::disjunction< // disjunction is C++17
99-
// feature, supported by DPC++
100-
td_ns::TypeMapResultEntry<T, std::uint8_t>,
101-
td_ns::TypeMapResultEntry<T, std::uint16_t>,
102-
td_ns::TypeMapResultEntry<T, std::uint32_t>,
103-
td_ns::TypeMapResultEntry<T, std::uint64_t>,
104-
td_ns::TypeMapResultEntry<T, std::int8_t>,
105-
td_ns::TypeMapResultEntry<T, std::int16_t>,
106-
td_ns::TypeMapResultEntry<T, std::int32_t>,
107-
td_ns::TypeMapResultEntry<T, std::int64_t>,
108-
td_ns::TypeMapResultEntry<T, sycl::half>,
109-
td_ns::TypeMapResultEntry<T, float>,
110-
td_ns::TypeMapResultEntry<T, double>,
111-
td_ns::DefaultResultEntry<void>>::result_type;
98+
using value_type =
99+
typename std::disjunction<td_ns::TypeMapResultEntry<T, std::uint8_t>,
100+
td_ns::TypeMapResultEntry<T, std::uint16_t>,
101+
td_ns::TypeMapResultEntry<T, std::uint32_t>,
102+
td_ns::TypeMapResultEntry<T, std::uint64_t>,
103+
td_ns::TypeMapResultEntry<T, std::int8_t>,
104+
td_ns::TypeMapResultEntry<T, std::int16_t>,
105+
td_ns::TypeMapResultEntry<T, std::int32_t>,
106+
td_ns::TypeMapResultEntry<T, std::int64_t>,
107+
td_ns::TypeMapResultEntry<T, sycl::half>,
108+
td_ns::TypeMapResultEntry<T, float>,
109+
td_ns::TypeMapResultEntry<T, double>,
110+
td_ns::DefaultResultEntry<void>>::result_type;
112111
};
113112

114113
template <typename T1, typename T2, unsigned int vec_sz, unsigned int n_vecs>

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/conj.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,7 @@ using ConjStridedFunctor = elementwise_common::
9999

100100
template <typename T> struct ConjOutputType
101101
{
102-
using value_type = typename std::disjunction< // disjunction is C++17
103-
// feature, supported by DPC++
102+
using value_type = typename std::disjunction<
104103
td_ns::TypeMapResultEntry<T, bool, int8_t>,
105104
td_ns::TypeMapResultEntry<T, std::uint8_t>,
106105
td_ns::TypeMapResultEntry<T, std::uint16_t>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/copysign.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ using CopysignStridedFunctor = elementwise_common::BinaryStridedFunctor<
104104

105105
template <typename T1, typename T2> struct CopysignOutputType
106106
{
107-
using value_type = typename std::disjunction< // disjunction is C++17
108-
// feature, supported by DPC++
107+
using value_type = typename std::disjunction<
109108
td_ns::BinaryTypeMapResultEntry<T1,
110109
sycl::half,
111110
T2,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/cos.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,7 @@ using CosStridedFunctor = elementwise_common::
180180

181181
template <typename T> struct CosOutputType
182182
{
183-
using value_type = typename std::disjunction< // disjunction is C++17
184-
// feature, supported by DPC++
183+
using value_type = typename std::disjunction<
185184
td_ns::TypeMapResultEntry<T, sycl::half, sycl::half>,
186185
td_ns::TypeMapResultEntry<T, float, float>,
187186
td_ns::TypeMapResultEntry<T, double, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/cosh.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,7 @@ using CoshStridedFunctor = elementwise_common::
170170

171171
template <typename T> struct CoshOutputType
172172
{
173-
using value_type = typename std::disjunction< // disjunction is C++17
174-
// feature, supported by DPC++
173+
using value_type = typename std::disjunction<
175174
td_ns::TypeMapResultEntry<T, sycl::half>,
176175
td_ns::TypeMapResultEntry<T, float>,
177176
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/equal.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,7 @@ using EqualStridedFunctor =
141141

142142
template <typename T1, typename T2> struct EqualOutputType
143143
{
144-
using value_type = typename std::disjunction< // disjunction is C++17
145-
// feature, supported by DPC++
144+
using value_type = typename std::disjunction<
146145
td_ns::BinaryTypeMapResultEntry<T1, bool, T2, bool, bool>,
147146
td_ns::
148147
BinaryTypeMapResultEntry<T1, std::uint8_t, T2, std::uint8_t, bool>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/exp.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,7 @@ using ExpStridedFunctor = elementwise_common::
139139

140140
template <typename T> struct ExpOutputType
141141
{
142-
using value_type = typename std::disjunction< // disjunction is C++17
143-
// feature, supported by DPC++
142+
using value_type = typename std::disjunction<
144143
td_ns::TypeMapResultEntry<T, sycl::half>,
145144
td_ns::TypeMapResultEntry<T, float>,
146145
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/exp2.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,7 @@ using Exp2StridedFunctor = elementwise_common::
141141

142142
template <typename T> struct Exp2OutputType
143143
{
144-
using value_type = typename std::disjunction< // disjunction is C++17
145-
// feature, supported by DPC++
144+
using value_type = typename std::disjunction<
146145
td_ns::TypeMapResultEntry<T, sycl::half>,
147146
td_ns::TypeMapResultEntry<T, float>,
148147
td_ns::TypeMapResultEntry<T, double>,

‎dpctl/tensor/libtensor/include/kernels/elementwise_functions/expm1.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,7 @@ using Expm1StridedFunctor = elementwise_common::
153153

154154
template <typename T> struct Expm1OutputType
155155
{
156-
using value_type = typename std::disjunction< // disjunction is C++17
157-
// feature, supported by DPC++
156+
using value_type = typename std::disjunction<
158157
td_ns::TypeMapResultEntry<T, sycl::half, sycl::half>,
159158
td_ns::TypeMapResultEntry<T, float, float>,
160159
td_ns::TypeMapResultEntry<T, double, double>,

0 commit comments

Comments
 (0)