Skip to content

Commit 7071b35

Browse files
Merge pull request #1039 from IntelPython/correct-preprocessor-exclusion-logic
Corrected behavior for DPCTL_ENABLE_L0_PROGRAM_CREATION=OFF
2 parents a7c3e8a + f404998 commit 7071b35

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

libsyclinterface/include/Config/dpctl_config.h.in

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@
2626
#pragma once
2727

2828
/* Defined when dpctl was built with level zero program creation enabled. */
29-
#cmakedefine DPCTL_ENABLE_L0_PROGRAM_CREATION \
30-
@DPCTL_ENABLE_L0_PROGRAM_CREATION@
29+
#cmakedefine DPCTL_ENABLE_L0_PROGRAM @DPCTL_ENABLE_L0_PROGRAM_CREATION@
3130

3231
#define __SYCL_COMPILER_VERSION_REQUIRED 20221201L
3332

libsyclinterface/source/dpctl_sycl_kernel_bundle_interface.cpp

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
#endif
4040
#include <sstream>
4141

42-
#ifdef DPCTL_ENABLE_L0_PROGRAM_CREATION
42+
#ifdef DPCTL_ENABLE_L0_PROGRAM
4343
// Note: include ze_api.h before level_zero.hpp. Make sure clang-format does
4444
// not reorder the includes.
4545
// clang-format off
@@ -332,7 +332,7 @@ _GetKernel_ocl_impl(const kernel_bundle<bundle_state::executable> &kb,
332332
}
333333
}
334334

335-
#ifdef DPCTL_ENABLE_L0_PROGRAM_CREATION
335+
#ifdef DPCTL_ENABLE_L0_PROGRAM
336336

337337
#ifdef __linux__
338338
static const char *zeLoaderName = DPCTL_LIBZE_LOADER_FILENAME;
@@ -579,7 +579,7 @@ bool _HasKernel_ze_impl(const kernel_bundle<bundle_state::executable> &kb,
579579
return false;
580580
}
581581

582-
#endif /* #ifdef DPCTL_ENABLE_L0_PROGRAM_CREATION */
582+
#endif /* #ifdef DPCTL_ENABLE_L0_PROGRAM */
583583

584584
} /* end of anonymous namespace */
585585

@@ -619,11 +619,11 @@ DPCTLKernelBundle_CreateFromSpirv(__dpctl_keep const DPCTLSyclContextRef CtxRef,
619619
length, CompileOpts);
620620
break;
621621
case backend::ext_oneapi_level_zero:
622-
#ifdef DPCTL_ENABLE_L0_PROGRAM_CREATION
622+
#ifdef DPCTL_ENABLE_L0_PROGRAM
623623
KBRef = _CreateKernelBundleWithIL_ze_impl(*SyclCtx, *SyclDev, IL,
624624
length, CompileOpts);
625-
#endif
626625
break;
626+
#endif
627627
default:
628628
error_handler("Backend " + std::to_string(static_cast<int>(BE)) +
629629
" is not supported",
@@ -671,8 +671,9 @@ __dpctl_give DPCTLSyclKernelBundleRef DPCTLKernelBundle_CreateFromOCLSource(
671671
}
672672
break;
673673
case backend::ext_oneapi_level_zero:
674-
error_handler("CreateFromSource is not supported in Level Zero.",
675-
__FILE__, __func__, __LINE__);
674+
error_handler(
675+
"CreateFromSource is not supported for Level Zero backend.",
676+
__FILE__, __func__, __LINE__);
676677
return nullptr;
677678
default:
678679
error_handler("CreateFromSource is not supported in unknown backend.",
@@ -700,7 +701,9 @@ DPCTLKernelBundle_GetKernel(__dpctl_keep DPCTLSyclKernelBundleRef KBRef,
700701
case sycl::backend::opencl:
701702
return _GetKernel_ocl_impl(*SyclKB, KernelName);
702703
case sycl::backend::ext_oneapi_level_zero:
704+
#ifdef DPCTL_ENABLE_L0_PROGRAM
703705
return _GetKernel_ze_impl(*SyclKB, KernelName);
706+
#endif
704707
default:
705708
error_handler("Backend " + std::to_string(static_cast<int>(be)) +
706709
" is not supported.",
@@ -728,7 +731,9 @@ bool DPCTLKernelBundle_HasKernel(__dpctl_keep DPCTLSyclKernelBundleRef KBRef,
728731
case sycl::backend::opencl:
729732
return _HasKernel_ocl_impl(*SyclKB, KernelName);
730733
case sycl::backend::ext_oneapi_level_zero:
734+
#ifdef DPCTL_ENABLE_L0_PROGRAM
731735
return _HasKernel_ze_impl(*SyclKB, KernelName);
736+
#endif
732737
default:
733738
error_handler("Backend " + std::to_string(static_cast<int>(be)) +
734739
" is not supported.",

0 commit comments

Comments
 (0)