Removes assumption that new array is writable

Now flags are set based on input regardless of whether a new array is writable
per review feedback

Author: ndgrigorian

dpctl/tensor/_usmarray.pyx

@@ -731,7 +731,7 @@ cdef class usm_ndarray:
         adv_ind_start_p = _meta[4]
 
         if adv_ind_start_p < 0:
-            res.flags_ ^= (~self.flags_ & USM_ARRAY_WRITABLE)
+            res.flags_ = (res.flags_ & ~USM_ARRAY_WRITABLE) | (self.flags_ & USM_ARRAY_WRITABLE)
             return res
 
         from ._copy_utils import _extract_impl, _nonzero_impl, _take_multi_index
@@ -749,7 +749,7 @@ cdef class usm_ndarray:
             if not matching:
                 raise IndexError("boolean index did not match indexed array in dimensions")
             res = _extract_impl(res, key_, axis=adv_ind_start_p)
-            res.flags_ ^= (~self.flags_ & USM_ARRAY_WRITABLE)
+            res.flags_ = (res.flags_ & ~USM_ARRAY_WRITABLE) | (self.flags_ & USM_ARRAY_WRITABLE)
             return res
 
         if any(ind.dtype == dpt_bool for ind in adv_ind):
@@ -760,11 +760,11 @@ cdef class usm_ndarray:
                 else:
                     adv_ind_int.append(ind)
             res = _take_multi_index(res, tuple(adv_ind_int), adv_ind_start_p)
-            res.flags_ ^= (~self.flags_ & USM_ARRAY_WRITABLE)
+            res.flags_ = (res.flags_ & ~USM_ARRAY_WRITABLE) | (self.flags_ & USM_ARRAY_WRITABLE)
             return res
 
         res = _take_multi_index(res, adv_ind, adv_ind_start_p)
-        res.flags_ ^= (~self.flags_ & USM_ARRAY_WRITABLE)
+        res.flags_ = (res.flags_ & ~USM_ARRAY_WRITABLE) | (self.flags_ & USM_ARRAY_WRITABLE)
         return res
 
     def to_device(self, target, stream=None):
@@ -1228,7 +1228,7 @@ cdef usm_ndarray _real_view(usm_ndarray ary):
         offset=offset_elems,
         order=('C' if (ary.flags_ & USM_ARRAY_C_CONTIGUOUS) else 'F')
     )
-    r.flags_ ^= (~ary.flags_ & USM_ARRAY_WRITABLE)
+    r.flags_ = (r.flags_ & ~USM_ARRAY_WRITABLE) | (ary.flags_ & USM_ARRAY_WRITABLE)
     r.array_namespace_ = ary.array_namespace_
     return r
 
@@ -1260,7 +1260,7 @@ cdef usm_ndarray _imag_view(usm_ndarray ary):
         offset=offset_elems,
         order=('C' if (ary.flags_ & USM_ARRAY_C_CONTIGUOUS) else 'F')
     )
-    r.flags_ ^= (~ary.flags_ & USM_ARRAY_WRITABLE)
+    r.flags_ = (r.flags_ & ~USM_ARRAY_WRITABLE) | (ary.flags_ & USM_ARRAY_WRITABLE)
     r.array_namespace_ = ary.array_namespace_
     return r
 
@@ -1280,7 +1280,7 @@ cdef usm_ndarray _transpose(usm_ndarray ary):
         order=('F' if (ary.flags_ & USM_ARRAY_C_CONTIGUOUS) else 'C'),
         offset=ary.get_offset()
     )
-    r.flags_ ^= (~ary.flags_ & USM_ARRAY_WRITABLE)
+    r.flags_ = (r.flags_ & ~USM_ARRAY_WRITABLE) | (ary.flags_ & USM_ARRAY_WRITABLE)
     return r
 
 
@@ -1297,7 +1297,7 @@ cdef usm_ndarray _m_transpose(usm_ndarray ary):
         order=('F' if (ary.flags_ & USM_ARRAY_C_CONTIGUOUS) else 'C'),
         offset=ary.get_offset()
     )
-    r.flags_ ^= (~ary.flags_ & USM_ARRAY_WRITABLE)
+    r.flags_ = (r.flags_ & ~USM_ARRAY_WRITABLE) | (ary.flags_ & USM_ARRAY_WRITABLE)
     return r