Skip to content

Commit 93db58a

Browse files
Renamed n_values->n_to_sort for readability per review
1 parent 446ce05 commit 93db58a

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

dpctl/tensor/libtensor/include/kernels/sorting/radix_sort.hpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1015,7 +1015,7 @@ struct subgroup_radix_sort
10151015
template <typename ValueT, typename OutputT, typename ProjT>
10161016
sycl::event operator()(sycl::queue &exec_q,
10171017
size_t n_iters,
1018-
size_t n_values,
1018+
size_t n_to_sort,
10191019
ValueT *input_ptr,
10201020
OutputT *output_ptr,
10211021
ProjT proj_op,
@@ -1038,7 +1038,8 @@ struct subgroup_radix_sort
10381038
std::min<std::size_t>(n_iters, max_concurrent_work_groups);
10391039

10401040
// determine which temporary allocation can be accommodated in SLM
1041-
const auto &SLM_availability = check_slm_size<ValueT>(exec_q, n_values);
1041+
const auto &SLM_availability =
1042+
check_slm_size<ValueT>(exec_q, n_to_sort);
10421043

10431044
const std::size_t n_batch_size = n_work_groups;
10441045

@@ -1049,7 +1050,7 @@ struct subgroup_radix_sort
10491050
constexpr auto storage_for_counters = use_slm_tag{};
10501051

10511052
return one_group_submitter<_SortKernelLoc>()(
1052-
exec_q, n_iters, n_iters, n_values, input_ptr, output_ptr,
1053+
exec_q, n_iters, n_iters, n_to_sort, input_ptr, output_ptr,
10531054
proj_op, is_ascending, storage_for_values, storage_for_counters,
10541055
depends);
10551056
}
@@ -1059,7 +1060,7 @@ struct subgroup_radix_sort
10591060
constexpr auto storage_for_counters = use_slm_tag{};
10601061

10611062
return one_group_submitter<_SortKernelPartGlob>()(
1062-
exec_q, n_iters, n_batch_size, n_values, input_ptr, output_ptr,
1063+
exec_q, n_iters, n_batch_size, n_to_sort, input_ptr, output_ptr,
10631064
proj_op, is_ascending, storage_for_values, storage_for_counters,
10641065
depends);
10651066
}
@@ -1069,7 +1070,7 @@ struct subgroup_radix_sort
10691070
constexpr auto storage_for_counters = use_global_mem_tag{};
10701071

10711072
return one_group_submitter<_SortKernelGlob>()(
1072-
exec_q, n_iters, n_batch_size, n_values, input_ptr, output_ptr,
1073+
exec_q, n_iters, n_batch_size, n_to_sort, input_ptr, output_ptr,
10731074
proj_op, is_ascending, storage_for_values, storage_for_counters,
10741075
depends);
10751076
}

0 commit comments

Comments
 (0)