Rename the constructor.

Diptorup Deb · Diptorup Deb · commit cae9fa00b090 · 2021-03-25T20:48:28.000-05:00
diff --git a/dpctl-capi/include/dpctl_sycl_context_interface.h b/dpctl-capi/include/dpctl_sycl_context_interface.h
@@ -72,9 +72,9 @@ DPCTLContext_Create(__dpctl_keep const DPCTLSyclDeviceRef DRef,
  */
 DPCTL_API
 __dpctl_give DPCTLSyclContextRef
-DPCTLContext_CreateForDevices(__dpctl_keep const DPCTLDeviceVectorRef DVRef,
-                              error_handler_callback *error_handler,
-                              int properties);
+DPCTLContext_CreateFromDevices(__dpctl_keep const DPCTLDeviceVectorRef DVRef,
+                               error_handler_callback *error_handler,
+                               int properties);
 
 /*!
  * @brief Checks if two DPCTLSyclContextRef objects point to the same
diff --git a/dpctl-capi/source/dpctl_sycl_context_interface.cpp b/dpctl-capi/source/dpctl_sycl_context_interface.cpp
@@ -62,9 +62,9 @@ DPCTLContext_Create(__dpctl_keep const DPCTLSyclDeviceRef DRef,
 }
 
 __dpctl_give DPCTLSyclContextRef
-DPCTLContext_CreateForDevices(__dpctl_keep const DPCTLDeviceVectorRef DVRef,
-                              error_handler_callback *error_handler,
-                              int /**/)
+DPCTLContext_CreateFromDevices(__dpctl_keep const DPCTLDeviceVectorRef DVRef,
+                               error_handler_callback *error_handler,
+                               int /**/)
 {
     DPCTLSyclContextRef CRef = nullptr;
     vector_class<device> Devices;
diff --git a/dpctl-capi/tests/test_sycl_context_interface.cpp b/dpctl-capi/tests/test_sycl_context_interface.cpp
@@ -102,7 +102,7 @@ TEST_P(TestDPCTLContextInterface, Chk_CreateWithDevices)
                 unwrap(DVRef)->emplace_back(wrap(new device(sd)));
             }
             EXPECT_NO_FATAL_FAILURE(
-                CRef = DPCTLContext_CreateForDevices(DVRef, nullptr, 0));
+                CRef = DPCTLContext_CreateFromDevices(DVRef, nullptr, 0));
             ASSERT_TRUE(CRef);
         } catch (feature_not_supported const &fnse) {
             GTEST_SKIP_("Skipping creating context for sub-devices");

Original file line number	Diff line number	Diff line change
`@@ -62,9 +62,9 @@ DPCTLContext_Create(__dpctl_keep const DPCTLSyclDeviceRef DRef,`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`__dpctl_give DPCTLSyclContextRef`
`65`		`-DPCTLContext_CreateForDevices(__dpctl_keep const DPCTLDeviceVectorRef DVRef,`
`66`		`- error_handler_callback *error_handler,`
`67`		`- int /**/)`
	`65`	`+DPCTLContext_CreateFromDevices(__dpctl_keep const DPCTLDeviceVectorRef DVRef,`
	`66`	`+ error_handler_callback *error_handler,`
	`67`	`+ int /**/)`
`68`	`68`	`{`
`69`	`69`	`DPCTLSyclContextRef CRef = nullptr;`
`70`	`70`	`vector_class<device> Devices;`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ TEST_P(TestDPCTLContextInterface, Chk_CreateWithDevices)`
`102`	`102`	`unwrap(DVRef)->emplace_back(wrap(new device(sd)));`
`103`	`103`	`}`
`104`	`104`	`EXPECT_NO_FATAL_FAILURE(`
`105`		`- CRef = DPCTLContext_CreateForDevices(DVRef, nullptr, 0));`
	`105`	`+ CRef = DPCTLContext_CreateFromDevices(DVRef, nullptr, 0));`
`106`	`106`	`ASSERT_TRUE(CRef);`
`107`	`107`	`} catch (feature_not_supported const &fnse) {`
`108`	`108`	`GTEST_SKIP_("Skipping creating context for sub-devices");`