Roll must reduce shift steps by size along axis

Closes gh-1857

Test added based on example provided in the issue.

Author: oleksandr-pavlyk

dpctl/tensor/_manipulation_functions.py

@@ -356,7 +356,7 @@ def roll(X, /, shift, *, axis=None):
         hev, roll_ev = ti._copy_usm_ndarray_for_roll_1d(
             src=X,
             dst=res,
-            shift=shift,
+            shift=(shift % X.size),
             sycl_queue=exec_q,
             depends=dep_evs,
         )
@@ -369,9 +369,11 @@ def roll(X, /, shift, *, axis=None):
     shifts = [
         0,
     ] * X.ndim
+    shape = X.shape
     for sh, ax in broadcasted:
-        shifts[ax] += sh
-
+        n_i = shape[ax]
+        if n_i > 0:
+            shifts[ax] = int(shifts[ax] + sh) % int(n_i)
     res = dpt.empty(
         X.shape, dtype=X.dtype, usm_type=X.usm_type, sycl_queue=exec_q
     )

dpctl/tests/test_usm_ndarray_manipulation.py

@@ -657,6 +657,16 @@ def test_roll_2d(data):
     assert_array_equal(Ynp, dpt.asnumpy(Y))
 
 
+def test_roll_out_bounds_shifts():
+    "See gh-1857"
+    get_queue_or_skip()
+
+    x = dpt.arange(4)
+    y = dpt.roll(x, np.uint64(2**63 + 2))
+    expected = dpt.roll(x, 2)
+    assert dpt.all(y == expected)
+
+
 def test_roll_validation():
     get_queue_or_skip()