Added tests and fixed typo in logical_not

Author: antonwolfy

dpctl/tensor/_elementwise_funcs.py

@@ -602,7 +602,7 @@
 
 # U24: ==== LOGICAL_NOT (x)
 _logical_not_docstring = """
-log(x, out=None, order='K')
+logical_not(x, out=None, order='K')
 Computes the logical NOT for each element `x_i` of input array `x`.
 Args:
     x (usm_ndarray):

dpctl/tensor/libtensor/include/kernels/elementwise_functions/logical_not.hpp

@@ -48,13 +48,13 @@ namespace py = pybind11;
 namespace td_ns = dpctl::tensor::type_dispatch;
 namespace tu_ns = dpctl::tensor::type_utils;
 
-template <typename argT, typename resT> struct LogicalNotFunctor
+template <typename argT, typename resT>
+struct LogicalNotFunctor
 {
     static_assert(std::is_same_v<resT, bool>);
 
-    using is_constant = typename std::disjunction<std::is_same<argT, bool>,
-                                                  std::is_integral<argT>>;
-    static constexpr resT constant_value = false;
+    using is_constant = typename std::false_type;
+    // constexpr resT constant_value = resT{};
     using supports_vec = typename std::false_type;
     using supports_sg_loadstore = typename std::negation<
         std::disjunction<tu_ns::is_complex<resT>, tu_ns::is_complex<argT>>>;
@@ -84,7 +84,8 @@ using LogicalNotStridedFunctor =
                                             IndexerT,
                                             LogicalNotFunctor<argTy, resTy>>;
 
-template <typename argTy> struct LogicalNotOutputType
+template <typename argTy>
+struct LogicalNotOutputType
 {
     using value_type = bool;
 };
@@ -94,19 +95,20 @@ class logical_not_contig_kernel;
 
 template <typename argTy>
 sycl::event
-logical_not_contig_impl(sycl::queue exec_q,
-                        size_t nelems,
-                        const char *arg_p,
-                        char *res_p,
-                        const std::vector<sycl::event> &depends = {})
+    logical_not_contig_impl(sycl::queue exec_q,
+                            size_t nelems,
+                            const char *arg_p,
+                            char *res_p,
+                            const std::vector<sycl::event> &depends = {})
 {
     return elementwise_common::unary_contig_impl<argTy, LogicalNotOutputType,
                                                  LogicalNotContigFunctor,
                                                  logical_not_contig_kernel>(
         exec_q, nelems, arg_p, res_p, depends);
 }
 
-template <typename fnT, typename T> struct LogicalNotContigFactory
+template <typename fnT, typename T>
+struct LogicalNotContigFactory
 {
     fnT get()
     {
@@ -115,7 +117,8 @@ template <typename fnT, typename T> struct LogicalNotContigFactory
     }
 };
 
-template <typename fnT, typename T> struct LogicalNotTypeMapFactory
+template <typename fnT, typename T>
+struct LogicalNotTypeMapFactory
 {
     /*! @brief get typeid for output type of sycl::logical_not(T x) */
     std::enable_if_t<std::is_same<fnT, int>::value, int> get()
@@ -130,16 +133,16 @@ class logical_not_strided_kernel;
 
 template <typename argTy>
 sycl::event
-logical_not_strided_impl(sycl::queue exec_q,
-                         size_t nelems,
-                         int nd,
-                         const py::ssize_t *shape_and_strides,
-                         const char *arg_p,
-                         py::ssize_t arg_offset,
-                         char *res_p,
-                         py::ssize_t res_offset,
-                         const std::vector<sycl::event> &depends,
-                         const std::vector<sycl::event> &additional_depends)
+    logical_not_strided_impl(sycl::queue exec_q,
+                             size_t nelems,
+                             int nd,
+                             const py::ssize_t *shape_and_strides,
+                             const char *arg_p,
+                             py::ssize_t arg_offset,
+                             char *res_p,
+                             py::ssize_t res_offset,
+                             const std::vector<sycl::event> &depends,
+                             const std::vector<sycl::event> &additional_depends)
 {
     return elementwise_common::unary_strided_impl<argTy, LogicalNotOutputType,
                                                   LogicalNotStridedFunctor,
@@ -148,7 +151,8 @@ logical_not_strided_impl(sycl::queue exec_q,
         res_offset, depends, additional_depends);
 }
 
-template <typename fnT, typename T> struct LogicalNotStridedFactory
+template <typename fnT, typename T>
+struct LogicalNotStridedFactory
 {
     fnT get()
     {