Skip to content

Changes to workflows to stabilize tests on CPU #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2023
Merged

Changes to workflows to stabilize tests on CPU #1212

merged 3 commits into from
May 23, 2023

Conversation

ndgrigorian
Copy link
Collaborator

This PR changes workflows to use SYCL_QUEUE_THREAD_POOL_SIZE=6 to stabilize sporadic crashes in the CI on CPU.
Also changes the array API conformity workflow to fail when array API conformity tests fail to run (i.e., when no JSON report is generated).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1212/index.html

@coveralls
Copy link
Collaborator

coveralls commented May 22, 2023 •
edited
Loading

Coverage Status

Coverage: 84.034%. Remained the same when pulling b895ed8 on stabilize-CI-thread-pool-size into 18d1728 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_117 ran successfully.
Passed: 228
Failed: 772
Skipped: 116

@ndgrigorian ndgrigorian force-pushed the stabilize-CI-thread-pool-size branch from f132d08 to 8cc5498 Compare May 23, 2023 02:53
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_117 ran successfully.
Passed: 227
Failed: 773
Skipped: 116

@ndgrigorian ndgrigorian force-pushed the stabilize-CI-thread-pool-size branch from 8cc5498 to cddb103 Compare May 23, 2023 05:12
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_117 ran successfully.
Passed: 227
Failed: 773
Skipped: 116

oleksandr-pavlyk
oleksandr-pavlyk reviewed May 23, 2023
View reviewed changes
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_118 ran successfully.
Passed: 228
Failed: 772
Skipped: 116

@ndgrigorian ndgrigorian marked this pull request as ready for review May 23, 2023 17:16
oleksandr-pavlyk
oleksandr-pavlyk reviewed May 23, 2023
View reviewed changes
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_119 ran successfully.
Passed: 226
Failed: 774
Skipped: 116

@ndgrigorian ndgrigorian merged commit c822d41 into master May 23, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_119 ran successfully.
Passed: 228
Failed: 772
Skipped: 116

@ndgrigorian ndgrigorian deleted the stabilize-CI-thread-pool-size branch July 27, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk