Skip to content

Modularized test_main tests #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Also added code to work around a bug with CPU runtime, which may cause DPC++ RT to not see CPU device in the sub-process if the parent process has initialized CPU plugin.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Also added code to work around a bug with CPU runtime, which
may cause DPC++ RT to not see CPU device in the sub-process
if the parent process has initialized CPU plugin.
Copy link

github-actions bot commented Feb 29, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.244%. remained the same
when pulling 7a6a1bf on change-test-main-to-work-around-a-problem
into d2d06fd on master.

Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_43 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1465451 into master Mar 1, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the change-test-main-to-work-around-a-problem branch March 1, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants