Skip to content

Improve dpctl.tensor.full error for invalid fill_value #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

* Improved error in constructors `tensor.full` and `tensor.full_like` when provided a non-numeric fill value [gh-1878](https://github.com/IntelPython/dpctl/pull/1878)

### Maintenance

* Update black version used in Python code style workflow [gh-1828](https://github.com/IntelPython/dpctl/pull/1828)
Expand Down
21 changes: 21 additions & 0 deletions dpctl/tensor/_ctors.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# limitations under the License.

import operator
from numbers import Number

import numpy as np

Expand Down Expand Up @@ -1110,6 +1111,16 @@ def full(
sycl_queue=sycl_queue,
)
return dpt.copy(dpt.broadcast_to(X, shape), order=order)
# TODO: verify if `np.True_` and `np.False_` should be instances of
# Number in NumPy, like other NumPy scalars and like Python bools
# check for `np.bool_` separately as NumPy<2 has no `np.bool`
elif not isinstance(fill_value, Number) and not isinstance(
fill_value, np.bool_
):
raise TypeError(
"`full` array cannot be constructed with value of type "
f"{type(fill_value)}"
)

sycl_queue = normalize_queue_device(sycl_queue=sycl_queue, device=device)
usm_type = usm_type if usm_type is not None else "device"
Expand Down Expand Up @@ -1480,6 +1491,16 @@ def full_like(
)
_manager.add_event_pair(hev, copy_ev)
return res
# TODO: verify if `np.True_` and `np.False_` should be instances of
# Number in NumPy, like other NumPy scalars and like Python bools
# check for `np.bool_` separately as NumPy<2 has no `np.bool`
elif not isinstance(fill_value, Number) and not isinstance(
fill_value, np.bool_
):
raise TypeError(
"`full` array cannot be constructed with value of type "
f"{type(fill_value)}"
)

dtype = _get_dtype(dtype, sycl_queue, ref_type=type(fill_value))
res = _empty_like_orderK(x, dtype, usm_type, sycl_queue)
Expand Down
11 changes: 11 additions & 0 deletions dpctl/tests/test_usm_ndarray_ctor.py
Original file line number Diff line number Diff line change
Expand Up @@ -2621,3 +2621,14 @@ def test_setitem_from_numpy_contig():

expected = dpt.reshape(dpt.arange(-10, 10, dtype=fp_dt), (4, 5))
assert dpt.all(dpt.flip(Xdpt, axis=-1) == expected)


def test_full_functions_raise_type_error():
get_queue_or_skip()

with pytest.raises(TypeError):
dpt.full(1, "0")

x = dpt.ones(1, dtype="i4")
with pytest.raises(TypeError):
dpt.full_like(x, "0")
Loading