Skip to content

Commit 10df422

Browse files
Skip check_zeros_shape_gesvd: works incorrently
1 parent 36fb8f2 commit 10df422

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

dpnp/backend/extensions/lapack/gesvd.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -158,14 +158,14 @@ std::pair<sycl::event, sycl::event>
158158
jobu_val, jobvt_val, expected_a_u_vt_ndim,
159159
expected_s_ndim);
160160

161-
// Ensure `m` and 'n' are non-zero, otherwise return empty
162-
// events
163-
if (gesvd_utils::check_zeros_shape_gesvd(a_array, out_s, out_u, out_vt,
164-
jobu_val, jobvt_val))
165-
{
166-
// nothing to do
167-
return std::make_pair(sycl::event(), sycl::event());
168-
}
161+
// // Ensure `m` and 'n' are non-zero, otherwise return empty
162+
// // events
163+
// if (gesvd_utils::check_zeros_shape_gesvd(a_array, out_s, out_u, out_vt,
164+
// jobu_val, jobvt_val))
165+
// {
166+
// // nothing to do
167+
// return std::make_pair(sycl::event(), sycl::event());
168+
// }
169169

170170
auto array_types = dpctl_td_ns::usm_ndarray_types();
171171
int a_array_type_id =

dpnp/backend/extensions/lapack/gesvd_batch.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -222,14 +222,14 @@ std::pair<sycl::event, sycl::event>
222222
jobu_val, jobvt_val, expected_a_u_vt_ndim,
223223
expected_s_ndim);
224224

225-
// Ensure `batch_size`, `m` and 'n' are non-zero, otherwise return empty
226-
// events
227-
if (gesvd_utils::check_zeros_shape_gesvd(a_array, out_s, out_u, out_vt,
228-
jobu_val, jobvt_val))
229-
{
230-
// nothing to do
231-
return std::make_pair(sycl::event(), sycl::event());
232-
}
225+
// // Ensure `batch_size`, `m` and 'n' are non-zero, otherwise return empty
226+
// // events
227+
// if (gesvd_utils::check_zeros_shape_gesvd(a_array, out_s, out_u, out_vt,
228+
// jobu_val, jobvt_val))
229+
// {
230+
// // nothing to do
231+
// return std::make_pair(sycl::event(), sycl::event());
232+
// }
233233

234234
auto array_types = dpctl_td_ns::usm_ndarray_types();
235235
int a_array_type_id =

0 commit comments

Comments
 (0)