address comments

Author: npolina4

dpnp/dpnp_array.py

@@ -600,8 +600,12 @@ def astype(self, dtype, order="K", casting="unsafe", subok=True, copy=True):
         """
         Copy the array with data type casting.
 
+        For full documentation refer to :obj:`numpy.ndarray.astype`.
+
         Parameters
         ----------
+        x1 : {dpnp.ndarray, usm_ndarray}
+            Array data type casting.
         dtype : dtype
             Target data type.
         order : {'C', 'F', 'A', 'K'}
@@ -611,12 +615,23 @@ def astype(self, dtype, order="K", casting="unsafe", subok=True, copy=True):
         copy : bool
             If it is False and no cast happens, then this method returns the array itself.
             Otherwise, a copy is returned.
+        casting : {'no', 'equiv', 'safe', 'same_kind', 'unsafe'}, optional
+            Controls what kind of data casting may occur. Defaults to 'unsafe' for backwards compatibility.
+            'no' means the data types should not be cast at all.
+            'equiv' means only byte-order changes are allowed.
+            'safe' means only casts which can preserve values are allowed.
+            'same_kind' means only safe casts or casts within a kind, like float64 to float32, are allowed.
+            'unsafe' means any data conversions may be done.
+        copy : bool, optional
+            By default, astype always returns a newly allocated array. If this is set to false, and the dtype,
+            order, and subok requirements are satisfied, the input array is returned instead of a copy.
 
         Returns
         -------
-        out : dpnp.ndarray
-            If ``copy`` is False and no cast is required, then the array itself is returned.
-            Otherwise, it returns a (possibly casted) copy of the array.
+        arr_t : dpnp.ndarray
+            Unless `copy` is ``False`` and the other conditions for returning the input array
+            are satisfied, `arr_t` is a new array of the same shape as the input array,
+            with dtype, order given by dtype, order.
 
         Limitations
         -----------
@@ -634,9 +649,12 @@ def astype(self, dtype, order="K", casting="unsafe", subok=True, copy=True):
 
         """
 
-        return dpnp.astype(
-            self, dtype, order=order, casting=casting, subok=subok, copy=copy
-        )
+        if subok is not True:
+            raise NotImplementedError(
+                f"subok={subok} is currently not supported"
+            )
+
+        return dpnp.astype(self, dtype, order=order, casting=casting, copy=copy)
 
     # 'base',
     # 'byteswap',

dpnp/dpnp_iface.py

@@ -150,12 +150,14 @@ def asnumpy(input, order="C"):
     return numpy.asarray(input, order=order)
 
 
-def astype(x1, dtype, order="K", casting="unsafe", subok=True, copy=True):
+def astype(x1, dtype, order="K", casting="unsafe", copy=True):
     """
     Copy the array with data type casting.
 
     Parameters
     ----------
+    x1 : {dpnp.ndarray, usm_ndarray}
+        Array data type casting.
     dtype : dtype
         Target data type.
     order : {'C', 'F', 'A', 'K'}
@@ -165,6 +167,16 @@ def astype(x1, dtype, order="K", casting="unsafe", subok=True, copy=True):
     copy : bool
         If it is False and no cast happens, then this method returns the array itself.
         Otherwise, a copy is returned.
+    casting : {'no', 'equiv', 'safe', 'same_kind', 'unsafe'}, optional
+        Controls what kind of data casting may occur. Defaults to 'unsafe' for backwards compatibility.
+        'no' means the data types should not be cast at all.
+        'equiv' means only byte-order changes are allowed.
+        'safe' means only casts which can preserve values are allowed.
+        'same_kind' means only safe casts or casts within a kind, like float64 to float32, are allowed.
+        'unsafe' means any data conversions may be done.
+    copy : bool, optional
+        By default, astype always returns a newly allocated array. If this is set to false, and the dtype,
+        order, and subok requirements are satisfied, the input array is returned instead of a copy.
 
     Returns
     -------
@@ -173,18 +185,8 @@ def astype(x1, dtype, order="K", casting="unsafe", subok=True, copy=True):
         are satisfied, `arr_t` is a new array of the same shape as the input array,
         with dtype, order given by dtype, order.
 
-    Limitations
-    -----------
-    Parameter `subok` is supported with default value.
-    Otherwise ``NotImplementedError`` exception will be raised.
-
     """
 
-    if subok is not True:
-        raise NotImplementedError(
-            f"Requested function={function.__name__} with subok={subok} isn't currently supported"
-        )
-
     if order is None:
         order = "K"
 

tests/skipped_tests.tbl

@@ -111,14 +111,12 @@ tests/test_umath.py::test_umaths[('spacing', 'd')]
 tests/third_party/cupy/core_tests/test_ndarray_complex_ops.py::TestAngle::test_angle
 tests/third_party/cupy/core_tests/test_ndarray_complex_ops.py::TestRealImag::test_imag_inplace
 tests/third_party/cupy/core_tests/test_ndarray_complex_ops.py::TestRealImag::test_real_inplace
-tests/third_party/cupy/core_tests/test_ndarray_complex_ops.py::TestScalarConversion::test_scalar_conversion
 tests/third_party/cupy/core_tests/test_ndarray_conversion.py::TestNdarrayToBytes_param_0_{shape=()}::test_item
 tests/third_party/cupy/core_tests/test_ndarray_conversion.py::TestNdarrayToBytes_param_1_{shape=(1,)}::test_item
 tests/third_party/cupy/core_tests/test_ndarray_conversion.py::TestNdarrayToBytes_param_2_{shape=(2, 3)}::test_item
 tests/third_party/cupy/core_tests/test_ndarray_conversion.py::TestNdarrayToBytes_param_3_{order='C', shape=(2, 3)}::test_item
 tests/third_party/cupy/core_tests/test_ndarray_conversion.py::TestNdarrayToBytes_param_4_{order='F', shape=(2, 3)}::test_item
 
-tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py::TestArrayAsType::test_astype_strides_broadcast
 tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py::TestArrayDiagonal::test_diagonal1
 tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py::TestArrayDiagonal::test_diagonal2
 tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py::TestArrayFlatten::test_flatten_order

tests/skipped_tests_gpu.tbl

@@ -240,9 +240,7 @@ tests/test_linalg.py::test_matrix_rank[None-[[1, 2], [3, 4]]-int32]
 tests/third_party/cupy/core_tests/test_ndarray_complex_ops.py::TestAngle::test_angle
 tests/third_party/cupy/core_tests/test_ndarray_complex_ops.py::TestRealImag::test_imag_inplace
 tests/third_party/cupy/core_tests/test_ndarray_complex_ops.py::TestRealImag::test_real_inplace
-tests/third_party/cupy/core_tests/test_ndarray_complex_ops.py::TestScalarConversion::test_scalar_conversion
 
-tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py::TestArrayAsType::test_astype_strides_broadcast
 tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py::TestArrayDiagonal::test_diagonal1
 tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py::TestArrayDiagonal::test_diagonal2
 tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py::TestArrayFlatten::test_flatten_order

tests/test_dparray.py

@@ -13,6 +13,7 @@
 )
 
 
+@pytest.mark.usefixtures("suppress_complex_warning")
 @pytest.mark.parametrize("res_dtype", get_all_dtypes())
 @pytest.mark.parametrize("arr_dtype", get_all_dtypes())
 @pytest.mark.parametrize(
@@ -28,6 +29,12 @@ def test_astype(arr, arr_dtype, res_dtype):
     assert_allclose(expected, result)
 
 
+def test_astype_subok_error():
+    x = dpnp.ones((4))
+    with pytest.raises(NotImplementedError):
+        x.astype("i4", subok=False)
+
+
 @pytest.mark.parametrize("arr_dtype", get_all_dtypes())
 @pytest.mark.parametrize(
     "arr",

tests/test_mathematical.py

@@ -1647,6 +1647,7 @@ def test_sum_empty_out(dtype):
     assert_array_equal(out.asnumpy(), numpy.array(0, dtype=dtype))
 
 
+@pytest.mark.usefixtures("suppress_complex_warning")
 @pytest.mark.parametrize(
     "shape",
     [