Skip to content

Commit 2e93f25

Browse files
Add q_ref as parametr to dpnp_memory_free_c and some fixies
1 parent 019189c commit 2e93f25

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

dpnp/backend/kernels/dpnp_krnl_random.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ DPCTLSyclEventRef dpnp_rng_binomial_c(DPCTLSyclQueueRef q_ref,
167167

168168
event_ref = dpnp_initval_c<_DataType>(q_ref, result, fill_value, size, dep_event_vec_ref);
169169
DPCTLEvent_Wait(event_ref);
170-
dpnp_memory_free_c(fill_value);
170+
dpnp_memory_free_c(q_ref, fill_value);
171171
}
172172
else
173173
{
@@ -598,7 +598,7 @@ DPCTLSyclEventRef dpnp_rng_gumbel_c(DPCTLSyclQueueRef q_ref,
598598

599599
event_ref = dpnp_initval_c<_DataType>(q_ref, result, fill_value, size, dep_event_vec_ref);
600600
DPCTLEvent_Wait(event_ref);
601-
dpnp_memory_free_c(fill_value);
601+
dpnp_memory_free_c(q_ref, fill_value);
602602
}
603603
else
604604
{
@@ -674,7 +674,7 @@ DPCTLSyclEventRef dpnp_rng_hypergeometric_c(DPCTLSyclQueueRef q_ref,
674674

675675
event_ref = dpnp_initval_c<_DataType>(q_ref, result, fill_value, size, dep_event_vec_ref);
676676
DPCTLEvent_Wait(event_ref);
677-
dpnp_memory_free_c(fill_value);
677+
dpnp_memory_free_c(q_ref, fill_value);
678678
}
679679
else
680680
{
@@ -882,7 +882,7 @@ DPCTLSyclEventRef dpnp_rng_lognormal_c(DPCTLSyclQueueRef q_ref,
882882

883883
event_ref = dpnp_initval_c<_DataType>(q_ref, result, fill_value, size, dep_event_vec_ref);
884884
DPCTLEvent_Wait(event_ref);
885-
dpnp_memory_free_c(fill_value);
885+
dpnp_memory_free_c(q_ref, fill_value);
886886
}
887887
else
888888
{
@@ -2909,8 +2909,6 @@ void func_map_init_random(func_map_t& fmap)
29092909

29102910
fmap[DPNPFuncName::DPNP_FN_RNG_SRAND][eft_DBL][eft_DBL] = {eft_DBL, (void*)dpnp_rng_srand_c};
29112911

2912-
// fmap[DPNPFuncName::DPNP_FN_RNG_SRAND_EXT][eft_DBL][eft_DBL] = {eft_DBL, (void*)dpnp_rng_srand_c};
2913-
29142912
fmap[DPNPFuncName::DPNP_FN_RNG_STANDARD_CAUCHY][eft_DBL][eft_DBL] = {
29152913
eft_DBL, (void*)dpnp_rng_standard_cauchy_default_c<double>};
29162914

@@ -2939,7 +2937,7 @@ void func_map_init_random(func_map_t& fmap)
29392937
eft_DBL, (void*)dpnp_rng_standard_t_default_c<double>};
29402938

29412939
fmap[DPNPFuncName::DPNP_FN_RNG_STANDARD_T_EXT][eft_DBL][eft_DBL] = {
2942-
eft_DBL, (void*)dpnp_rng_standard_normal_ext_c<double>};
2940+
eft_DBL, (void*)dpnp_rng_standard_t_ext_c<double>};
29432941

29442942
fmap[DPNPFuncName::DPNP_FN_RNG_TRIANGULAR][eft_DBL][eft_DBL] = {eft_DBL,
29452943
(void*)dpnp_rng_triangular_default_c<double>};

dpnp/linalg/dpnp_algo_linalg.pyx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,8 +484,7 @@ cpdef tuple dpnp_qr(utils.dpnp_descriptor x1, str mode):
484484
tau.get_data(),
485485
size_m,
486486
size_n,
487-
NULL)
488-
# dep_events_ref
487+
NULL) # dep_events_ref
489488

490489
with nogil: c_dpctl.DPCTLEvent_WaitAndThrow(event_ref)
491490
c_dpctl.DPCTLEvent_Delete(event_ref)

dpnp/random/dpnp_algo_random.pyx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,6 @@ cpdef utils.dpnp_descriptor dpnp_rng_multivariate_normal(utils.dpnp_descriptor m
795795
func(result.get_data(), mean_size, mean.get_data(), mean_size, cov.get_data(), cov_size, result.size)
796796

797797
return result
798-
799798

800799
cpdef utils.dpnp_descriptor dpnp_rng_negative_binomial(double a, double p, size):
801800
"""
@@ -1104,6 +1103,9 @@ cpdef utils.dpnp_descriptor dpnp_rng_random(dims):
11041103
# call FPTR function
11051104
cdef c_dpctl.DPCTLSyclEventRef event_ref = func(q_ref, result.get_data(), low, high, result.size, NULL)
11061105

1106+
with nogil: c_dpctl.DPCTLEvent_WaitAndThrow(event_ref)
1107+
c_dpctl.DPCTLEvent_Delete(event_ref)
1108+
11071109
return result
11081110

11091111

0 commit comments

Comments
 (0)