Skip to content

Commit 392c2ab

Browse files
committed
remove pytest skip
1 parent 64b95c4 commit 392c2ab

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

dpnp/dpnp_iface_manipulation.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2225,7 +2225,9 @@ def reshape(a, /, shape=None, order="C", *, newshape=None, copy=None):
22252225
elif order in "aA":
22262226
order = "F" if a.flags.fnc else "C"
22272227
elif order not in "cfCF":
2228-
raise ValueError(f"order must be None, 'C', 'F', or 'A' (got {order})")
2228+
raise ValueError(
2229+
f"order must be None, 'C', 'F', or 'A' (got '{order}')"
2230+
)
22292231

22302232
usm_a = dpnp.get_usm_ndarray(a)
22312233
usm_res = dpt.reshape(usm_a, shape=shape, order=order, copy=copy)

tests/third_party/cupy/manipulation_tests/test_shape.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import pytest
33

44
import dpnp as cupy
5+
from tests.helper import has_support_aspect64
56
from tests.third_party.cupy import testing
67

78

@@ -93,21 +94,19 @@ def test_reshape_zerosize_invalid_unknown(self):
9394
with pytest.raises(ValueError):
9495
a.reshape((-1, 0))
9596

96-
@pytest.mark.skip("array.base is not implemented")
97-
@testing.numpy_cupy_array_equal()
97+
@testing.numpy_cupy_array_equal(type_check=has_support_aspect64())
9898
def test_reshape_zerosize(self, xp):
9999
a = xp.zeros((0,))
100100
b = a.reshape((0,))
101-
assert b.base is a
101+
# assert b.base is a
102102
return b
103103

104-
@pytest.mark.skip("array.base is not implemented")
105104
@testing.for_orders("CFA")
106-
@testing.numpy_cupy_array_equal(strides_check=True)
105+
@testing.numpy_cupy_array_equal(type_check=has_support_aspect64())
107106
def test_reshape_zerosize2(self, xp, order):
108107
a = xp.zeros((2, 0, 3))
109108
b = a.reshape((5, 0, 4), order=order)
110-
assert b.base is a
109+
# assert b.base is a
111110
return b
112111

113112
@testing.for_orders("CFA")

0 commit comments

Comments
 (0)