address comments

Author: vtavana

dpnp/dpnp_algo/dpnp_elementwise_common.py

@@ -1834,7 +1834,7 @@ def dpnp_logical_xor(x1, x2, out=None, order="K"):
         Default: "K".
 Returns:
     dpnp.ndarray:
-        An array containing the element-wise minima. The data type of
+        An array containing the element-wise maxima. The data type of
         the returned array is determined by the Type Promotion Rules.
 """
 
@@ -1880,7 +1880,7 @@ def dpnp_maximum(x1, x2, out=None, order="K"):
         Default: "K".
 Returns:
     dpnp.ndarray:
-        An array containing the element-wise maxima. The data type of
+        An array containing the element-wise minima. The data type of
         the returned array is determined by the Type Promotion Rules.
 """
 

dpnp/dpnp_iface_mathematical.py

@@ -995,12 +995,13 @@ def fmax(x1, x2, /, out=None, *, where=True, dtype=None, subok=True, **kwargs):
     Parameters `where`, `dtype` and `subok` are supported with their default values.
     Keyword argument `kwargs` is currently unsupported.
     Otherwise the function will be executed sequentially on CPU.
-    Input array data types are limited by supported DPNP :ref:`Data types`.
+    Input array data types are limited by real-valued data types.
 
     See Also
     --------
-    :obj:`dpnp.maximum` : Element-wise maximum of array elements, propagates NaNs..
+    :obj:`dpnp.maximum` : Element-wise maximum of array elements, propagates NaNs.
     :obj:`dpnp.fmin` : Element-wise minimum of array elements, ignore NaNs.
+    :obj:`dpnp.minimum` : Element-wise minimum of array elements, propagates NaNs.
     :obj:`dpnp.fmod` : Calculate the element-wise remainder of division.
 
     Examples
@@ -1099,12 +1100,13 @@ def fmin(x1, x2, /, out=None, *, where=True, dtype=None, subok=True, **kwargs):
     Parameters `where`, `dtype` and `subok` are supported with their default values.
     Keyword argument `kwargs` is currently unsupported.
     Otherwise the function will be executed sequentially on CPU.
-    Input array data types are limited by supported DPNP :ref:`Data types`.
+    Input array data types are limited by real-valued data types.
 
     See Also
     --------
     :obj:`dpnp.minimum` : Element-wise minimum of array elements, propagates NaNs.
     :obj:`dpnp.fmax` : Element-wise maximum of array elements, ignore NaNs.
+    :obj:`dpnp.maximum` : Element-wise maximum of array elements, propagates NaNs.
     :obj:`dpnp.fmod` : Calculate the element-wise remainder of division.
 
     Examples
@@ -1440,7 +1442,7 @@ def maximum(
     >>> x1 = np.array([np.nan, 0, np.nan])
     >>> x2 = np.array([0, np.nan, np.nan])
     >>> np.maximum(x1, x2)
-    array([ nan,  nan, nan])
+    array([nan, nan, nan])
 
     >>> np.maximum(np.array(np.Inf), 1)
     array(inf)
@@ -1519,7 +1521,7 @@ def minimum(
     >>> x1 = np.array([np.nan, 0, np.nan])
     >>> x2 = np.array([0, np.nan, np.nan])
     >>> np.minimum(x1, x2)
-    array([ nan,  nan, nan])
+    array([nan, nan, nan])
 
     >>> np.minimum(np.array(-np.Inf), 1)
     array(-inf)

tests/test_mathematical.py

@@ -159,6 +159,18 @@ def test_copysign(self, dtype, lhs, rhs):
     def test_divide(self, dtype, lhs, rhs):
         self._test_mathematical("divide", dtype, lhs, rhs)
 
+    @pytest.mark.parametrize(
+        "dtype", get_all_dtypes(no_bool=True, no_complex=True)
+    )
+    def test_fmax(self, dtype, lhs, rhs):
+        self._test_mathematical("fmax", dtype, lhs, rhs, check_type=False)
+
+    @pytest.mark.parametrize(
+        "dtype", get_all_dtypes(no_bool=True, no_complex=True)
+    )
+    def test_fmin(self, dtype, lhs, rhs):
+        self._test_mathematical("fmin", dtype, lhs, rhs, check_type=False)
+
     @pytest.mark.usefixtures("allow_fall_back_on_numpy")
     @pytest.mark.parametrize(
         "dtype", get_all_dtypes(no_bool=True, no_complex=True)

tests/test_strides.py

@@ -164,6 +164,8 @@ def test_strides_reciprocal(dtype, shape):
         "add",
         "arctan2",
         "divide",
+        "fmax",
+        "fmin",
         "hypot",
         "maximum",
         "minimum",

tests/test_sycl_queue.py

@@ -357,6 +357,8 @@ def test_proj(device):
         pytest.param(
             "floor_divide", [1.0, 2.0, 3.0, 4.0], [2.5, 2.5, 2.5, 2.5]
         ),
+        pytest.param("fmax", [2.0, 3.0, 4.0], [1.0, 5.0, 2.0]),
+        pytest.param("fmin", [2.0, 3.0, 4.0], [1.0, 5.0, 2.0]),
         pytest.param(
             "fmod",
             [-3.0, -2.0, -1.0, 1.0, 2.0, 3.0],

tests/test_usm_type.py

@@ -356,6 +356,16 @@ def test_1in_1out(func, data, usm_type):
             [[0.0, 1.0, 2.0], [3.0, 4.0, 5.0]],
             [[4.0, 4.0], [4.0, 4.0], [4.0, 4.0]],
         ),
+        pytest.param(
+            "fmax",
+            [[0.0, 1.0, 2.0]],
+            [[3.0, 4.0, 5.0]],
+        ),
+        pytest.param(
+            "fmin",
+            [[0.0, 1.0, 2.0]],
+            [[3.0, 4.0, 5.0]],
+        ),
         pytest.param(
             "maximum",
             [[0.0, 1.0, 2.0]],