Skip to content

Commit 76e3f87

Browse files
authored
Merge pull request #1583 from IntelPython/cleanup_logic_func
Clean up old implementation of logic functions
2 parents 3d11b5c + 4233e10 commit 76e3f87

File tree

2 files changed

+7
-63
lines changed

2 files changed

+7
-63
lines changed

dpnp/backend/include/dpnp_iface_fptr.hpp

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,6 @@ enum class DPNPFuncName : size_t
158158
DPNP_FN_EIGVALS, /**< Used in numpy.linalg.eigvals() impl */
159159
DPNP_FN_EIGVALS_EXT, /**< Used in numpy.linalg.eigvals() impl, requires
160160
extra parameters */
161-
DPNP_FN_EQUAL_EXT, /**< Used in numpy.equal() impl, requires extra
162-
parameters */
163161
DPNP_FN_ERF, /**< Used in scipy.special.erf impl */
164162
DPNP_FN_ERF_EXT, /**< Used in scipy.special.erf impl, requires extra
165163
parameters */
@@ -196,12 +194,8 @@ enum class DPNPFuncName : size_t
196194
*/
197195
DPNP_FN_FULL, /**< Used in numpy.full() impl */
198196
DPNP_FN_FULL_LIKE, /**< Used in numpy.full_like() impl */
199-
DPNP_FN_GREATER_EXT, /**< Used in numpy.greater() impl, requires extra
200-
parameters */
201-
DPNP_FN_GREATER_EQUAL_EXT, /**< Used in numpy.greater_equal() impl, requires
202-
extra parameters */
203-
DPNP_FN_HYPOT, /**< Used in numpy.hypot() impl */
204-
DPNP_FN_IDENTITY, /**< Used in numpy.identity() impl */
197+
DPNP_FN_HYPOT, /**< Used in numpy.hypot() impl */
198+
DPNP_FN_IDENTITY, /**< Used in numpy.identity() impl */
205199
DPNP_FN_INITVAL, /**< Used in numpy ones, ones_like, zeros, zeros_like impls
206200
*/
207201
DPNP_FN_INITVAL_EXT, /**< Used in numpy ones, ones_like, zeros, zeros_like
@@ -214,15 +208,11 @@ enum class DPNPFuncName : size_t
214208
DPNP_FN_KRON_EXT, /**< Used in numpy.kron() impl, requires extra parameters
215209
*/
216210
DPNP_FN_LEFT_SHIFT, /**< Used in numpy.left_shift() impl */
217-
DPNP_FN_LESS_EXT, /**< Used in numpy.less() impl, requires extra parameters
218-
*/
219-
DPNP_FN_LESS_EQUAL_EXT, /**< Used in numpy.less_equal() impl, requires extra
220-
parameters */
221-
DPNP_FN_LOG, /**< Used in numpy.log() impl */
222-
DPNP_FN_LOG10, /**< Used in numpy.log10() impl */
223-
DPNP_FN_LOG10_EXT, /**< Used in numpy.log10() impl, requires extra
224-
parameters */
225-
DPNP_FN_LOG2, /**< Used in numpy.log2() impl */
211+
DPNP_FN_LOG, /**< Used in numpy.log() impl */
212+
DPNP_FN_LOG10, /**< Used in numpy.log10() impl */
213+
DPNP_FN_LOG10_EXT, /**< Used in numpy.log10() impl, requires extra
214+
parameters */
215+
DPNP_FN_LOG2, /**< Used in numpy.log2() impl */
226216
DPNP_FN_LOG2_EXT, /**< Used in numpy.log2() impl, requires extra parameters
227217
*/
228218
DPNP_FN_LOG1P, /**< Used in numpy.log1p() impl */
@@ -259,8 +249,6 @@ enum class DPNPFuncName : size_t
259249
parameters */
260250
DPNP_FN_NEGATIVE, /**< Used in numpy.negative() impl */
261251
DPNP_FN_NONZERO, /**< Used in numpy.nonzero() impl */
262-
DPNP_FN_NOT_EQUAL_EXT, /**< Used in numpy.not_equal() impl, requires extra
263-
parameters */
264252
DPNP_FN_ONES, /**< Used in numpy.ones() impl */
265253
DPNP_FN_ONES_LIKE, /**< Used in numpy.ones_like() impl */
266254
DPNP_FN_PARTITION, /**< Used in numpy.partition() impl */

dpnp/backend/kernels/dpnp_krnl_logic.cpp

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -667,47 +667,6 @@ DPCTLSyclEventRef (*dpnp_any_ext_c)(DPCTLSyclQueueRef,
667667
const DPCTLEventVectorRef) = \
668668
__name__<_DataType_input1, _DataType_input2>;
669669

670-
#include <dpnp_gen_2arg_2type_tbl.hpp>
671-
672-
template <DPNPFuncType FT1, DPNPFuncType... FTs>
673-
static void func_map_logic_2arg_2type_core(func_map_t &fmap)
674-
{
675-
((fmap[DPNPFuncName::DPNP_FN_EQUAL_EXT][FT1][FTs] =
676-
{eft_BLN, (void *)dpnp_equal_c_ext<func_type_map_t::find_type<FT1>,
677-
func_type_map_t::find_type<FTs>>}),
678-
...);
679-
((fmap[DPNPFuncName::DPNP_FN_GREATER_EXT][FT1][FTs] =
680-
{eft_BLN,
681-
(void *)dpnp_greater_c_ext<func_type_map_t::find_type<FT1>,
682-
func_type_map_t::find_type<FTs>>}),
683-
...);
684-
((fmap[DPNPFuncName::DPNP_FN_GREATER_EQUAL_EXT][FT1][FTs] =
685-
{eft_BLN,
686-
(void *)dpnp_greater_equal_c_ext<func_type_map_t::find_type<FT1>,
687-
func_type_map_t::find_type<FTs>>}),
688-
...);
689-
((fmap[DPNPFuncName::DPNP_FN_LESS_EXT][FT1][FTs] =
690-
{eft_BLN, (void *)dpnp_less_c_ext<func_type_map_t::find_type<FT1>,
691-
func_type_map_t::find_type<FTs>>}),
692-
...);
693-
((fmap[DPNPFuncName::DPNP_FN_LESS_EQUAL_EXT][FT1][FTs] =
694-
{eft_BLN,
695-
(void *)dpnp_less_equal_c_ext<func_type_map_t::find_type<FT1>,
696-
func_type_map_t::find_type<FTs>>}),
697-
...);
698-
((fmap[DPNPFuncName::DPNP_FN_NOT_EQUAL_EXT][FT1][FTs] =
699-
{eft_BLN,
700-
(void *)dpnp_not_equal_c_ext<func_type_map_t::find_type<FT1>,
701-
func_type_map_t::find_type<FTs>>}),
702-
...);
703-
}
704-
705-
template <DPNPFuncType... FTs>
706-
static void func_map_logic_2arg_2type_helper(func_map_t &fmap)
707-
{
708-
((func_map_logic_2arg_2type_core<FTs, FTs...>(fmap)), ...);
709-
}
710-
711670
void func_map_init_logic(func_map_t &fmap)
712671
{
713672
fmap[DPNPFuncName::DPNP_FN_ALL][eft_BLN][eft_BLN] = {
@@ -798,8 +757,5 @@ void func_map_init_logic(func_map_t &fmap)
798757
fmap[DPNPFuncName::DPNP_FN_ANY][eft_DBL][eft_DBL] = {
799758
eft_DBL, (void *)dpnp_any_default_c<double, bool>};
800759

801-
func_map_logic_2arg_2type_helper<eft_BLN, eft_INT, eft_LNG, eft_FLT,
802-
eft_DBL>(fmap);
803-
804760
return;
805761
}

0 commit comments

Comments
 (0)