Add additional checks for rcond parameter

Author: vlad-perevezentsev

dpnp/linalg/dpnp_iface_linalg.py

@@ -489,10 +489,10 @@ def pinv(a, rcond=1e-15, hermitian=False):
     ----------
     a : (..., M, N) {dpnp.ndarray, usm_ndarray}
         Matrix or stack of matrices to be pseudo-inverted.
-    rcond : {float, array_like}, optional
+    rcond : {float, dpnp.ndarray, usm_ndarray}, optional
         Cutoff for small singular values.
         Singular values less than or equal to ``rcond * largest_singular_value``
-        are set to zero.
+        are set to zero. Broadcasts against the stack of matrices.
         Default: ``1e-15``.
     hermitian : bool, optional
         If ``True``, a is assumed to be Hermitian (symmetric if real-valued),
@@ -520,6 +520,7 @@ def pinv(a, rcond=1e-15, hermitian=False):
     """
 
     dpnp.check_supported_arrays_type(a)
+    dpnp.check_supported_arrays_type(rcond, scalar_type=True)
     check_stacked_2d(a)
 
     return dpnp_pinv(a, rcond=rcond, hermitian=hermitian)

dpnp/linalg/dpnp_utils_linalg.py

@@ -1010,7 +1010,6 @@ def dpnp_pinv(a, rcond=1e-15, hermitian=False):
 
     """
 
-    rcond = dpnp.array(rcond, usm_type=a.usm_type, sycl_queue=a.sycl_queue)
     if a.size == 0:
         m, n = a.shape[-2:]
         if m == 0 or n == 0:
@@ -1019,6 +1018,14 @@ def dpnp_pinv(a, rcond=1e-15, hermitian=False):
             res_type = _common_type(a)
         return dpnp.empty_like(a, shape=(a.shape[:-2] + (n, m)), dtype=res_type)
 
+    if dpnp.is_supported_array_type(rcond):
+        # Check that `a` and `rcond` are allocated on the same device
+        # and have the same queue. Otherwise, `ValueError`` will be raised.
+        get_usm_allocations([a, rcond])
+    else:
+        # Allocate dpnp.ndarray if rcond is a scalar
+        rcond = dpnp.array(rcond, usm_type=a.usm_type, sycl_queue=a.sycl_queue)
+
     u, s, vt = dpnp_svd(a.conj(), full_matrices=False, hermitian=hermitian)
 
     # discard small singular values

tests/test_linalg.py

@@ -1289,10 +1289,26 @@ def test_pinv_strides(self):
     def test_pinv_errors(self):
         a_dp = inp.array([[1, 2], [3, 4]], dtype="float32")
 
-        # unsupported type
+        # unsupported type `a`
         a_np = inp.asnumpy(a_dp)
         assert_raises(TypeError, inp.linalg.pinv, a_np)
 
+        # unsupported type `rcond`
+        rcond = numpy.array(0.5, dtype="float32")
+        assert_raises(TypeError, inp.linalg.pinv, a_dp, rcond)
+        assert_raises(TypeError, inp.linalg.pinv, a_dp, [0.5])
+
+        # non-broadcastable `rcond`
+        rcond_dp = inp.array([0.5], dtype="float32")
+        assert_raises(ValueError, inp.linalg.pinv, a_dp, rcond_dp)
+
         # a.ndim < 2
         a_dp_ndim_1 = a_dp.flatten()
         assert_raises(inp.linalg.LinAlgError, inp.linalg.pinv, a_dp_ndim_1)
+
+        # diffetent queue
+        a_queue = dpctl.SyclQueue()
+        rcond_queue = dpctl.SyclQueue()
+        a_dp_q = inp.array(a_dp, sycl_queue=a_queue)
+        rcond_dp_q = inp.array([0.5], dtype="float32", sycl_queue=rcond_queue)
+        assert_raises(ValueError, inp.linalg.pinv, a_dp_q, rcond_dp_q)