Address remarks

Author: vlad-perevezentsev

dpnp/backend/extensions/lapack/gesvd.cpp

@@ -66,7 +66,7 @@ static gesvd_impl_fn_ptr_t gesvd_dispatch_table[dpctl_td_ns::num_types]
 
 // Converts a given character code (ord) to the corresponding
 // oneapi::mkl::jobsvd enumeration value
-oneapi::mkl::jobsvd process_job(std::int8_t job_val)
+static oneapi::mkl::jobsvd process_job(std::int8_t job_val)
 {
     switch (job_val) {
     case 'A':

dpnp/dpnp_algo/dpnp_algo.pxd

@@ -187,7 +187,6 @@ cdef extern from "dpnp_iface_fptr.hpp" namespace "DPNPFuncName":  # need this na
         DPNP_FN_SORT_EXT
         DPNP_FN_SUM
         DPNP_FN_SUM_EXT
-        DPNP_FN_SVD
         DPNP_FN_TRACE
         DPNP_FN_TRACE_EXT
         DPNP_FN_TRANSPOSE

dpnp/linalg/dpnp_iface_linalg.py

@@ -646,6 +646,8 @@ def svd(a, full_matrices=True, compute_uv=True, hermitian=False):
     check_stacked_2d(a)
 
     if hermitian is True:
-        raise ValueError("The hermitian argument is only supported as False")
+        raise NotImplementedError(
+            "hermitian keyword argument is only supported with its default value."
+        )
 
     return dpnp_svd(a, full_matrices, compute_uv)

dpnp/linalg/dpnp_utils_linalg.py

@@ -595,36 +595,29 @@ def dpnp_svd(a, full_matrices=True, compute_uv=True):
             )
             if compute_uv:
                 if full_matrices:
-                    u = dpnp.eye(
-                        n,
-                        dtype=uv_type,
-                        usm_type=a_usm_type,
-                        sycl_queue=a_sycl_queue,
-                    )
-                    vt = dpnp.eye(
-                        m,
-                        dtype=uv_type,
-                        usm_type=a_usm_type,
-                        sycl_queue=a_sycl_queue,
-                    )
+                    u_shape = (n,)
+                    vt_shape = (m,)
                 else:
-                    u = dpnp.empty(
-                        (n, 0),
-                        dtype=uv_type,
-                        usm_type=a_usm_type,
-                        sycl_queue=a_sycl_queue,
-                    )
-                    vt = dpnp.empty(
-                        (0, m),
-                        dtype=uv_type,
-                        usm_type=a_usm_type,
-                        sycl_queue=a_sycl_queue,
-                    )
+                    u_shape = (n, 0)
+                    vt_shape = (0, m)
+
+                u = dpnp.eye(
+                    *u_shape,
+                    dtype=uv_type,
+                    usm_type=a_usm_type,
+                    sycl_queue=a_sycl_queue,
+                )
+                vt = dpnp.eye(
+                    *vt_shape,
+                    dtype=uv_type,
+                    usm_type=a_usm_type,
+                    sycl_queue=a_sycl_queue,
+                )
                 return u, s, vt
             else:
                 return s
 
-        # `a`` must be copied because gesvd destroys the input matrix
+        # `a` must be copied because gesvd destroys the input matrix
         # `a` must be traspotted if m < n
         if m >= n:
             x = a
@@ -647,46 +640,32 @@ def dpnp_svd(a, full_matrices=True, compute_uv=True):
         k = n  # = min(m, n) where m >= n is ensured above
         if compute_uv:
             if full_matrices:
-                u_h = dpnp.empty(
-                    (m, m),
-                    dtype=uv_type,
-                    usm_type=a_usm_type,
-                    sycl_queue=a_sycl_queue,
-                )
-                vt_h = dpnp.empty(
-                    (n, n),
-                    dtype=uv_type,
-                    usm_type=a_usm_type,
-                    sycl_queue=a_sycl_queue,
-                )
+                u_shape = (m, m)
+                vt_shape = (n, n)
                 jobu = ord("A")
                 jobvt = ord("A")
             else:
-                u_h = dpnp.empty_like(x, dtype=uv_type)
-                vt_h = dpnp.empty(
-                    (k, n),
-                    dtype=uv_type,
-                    usm_type=a_usm_type,
-                    sycl_queue=a_sycl_queue,
-                )
+                u_shape = x.shape
+                vt_shape = (k, n)
                 jobu = ord("S")
                 jobvt = ord("S")
         else:
-            u_h = dpnp.empty(
-                [],
-                dtype=uv_type,
-                usm_type=a_usm_type,
-                sycl_queue=a_sycl_queue,
-            )
-            vt_h = dpnp.empty(
-                [],
-                dtype=uv_type,
-                usm_type=a_usm_type,
-                sycl_queue=a_sycl_queue,
-            )
+            u_shape = vt_shape = ()
             jobu = ord("N")
             jobvt = ord("N")
 
+        u_h = dpnp.empty(
+            u_shape,
+            dtype=uv_type,
+            usm_type=a_usm_type,
+            sycl_queue=a_sycl_queue,
+        )
+        vt_h = dpnp.empty(
+            vt_shape,
+            dtype=uv_type,
+            usm_type=a_usm_type,
+            sycl_queue=a_sycl_queue,
+        )
         s_h = dpnp.empty(
             k, dtype=s_type, usm_type=a_usm_type, sycl_queue=a_sycl_queue
         )

tests/test_linalg.py

@@ -644,7 +644,7 @@ def test_svd_errors(self):
         assert_raises(TypeError, inp.linalg.svd, a_np)
 
         # unsupported hermitian argument
-        assert_raises(ValueError, inp.linalg.svd, a_dp, hermitian=True)
+        assert_raises(NotImplementedError, inp.linalg.svd, a_dp, hermitian=True)
 
         # a.ndim < 2
         a_dp_ndim_1 = a_dp.flatten()