Skip to content

Commit c540be3

Browse files
Apply review remarks
1 parent e4ab84e commit c540be3

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,13 @@ if(_use_onemkl_interfaces)
128128

129129
FetchContent_MakeAvailable(onemkl_interfaces_library)
130130
if(TARGET onemath)
131-
set(USED_MATH_LIBRARY "onemath" CACHE INTERNAL "Selected OneAPI math library")
131+
set(MKL_INTERFACES_LIB "onemath" CACHE INTERNAL "OneMath lib target")
132132
elseif(TARGET onemkl)
133-
set(USED_MATH_LIBRARY "onemkl" CACHE INTERNAL "Selected OneAPI math library")
133+
set(MKL_INTERFACES_LIB "onemkl" CACHE INTERNAL "OneMath lib target")
134134
else()
135-
message(STATUS "Neither 'oneMath' nor 'oneMKL' found!")
135+
message(FATAL_ERROR "Neither 'oneMath' nor 'oneMKL' found!")
136136
endif()
137-
message(STATUS "OneAPI math library used: ${USED_MATH_LIBRARY}")
137+
message(STATUS "OneMath lib target used: ${MKL_INTERFACES_LIB}")
138138
set(CMAKE_INSTALL_RPATH "${CMAKE_BINARY_DIR}/lib")
139139
endif()
140140

dpnp/backend/extensions/blas/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ if (DPNP_GENERATE_COVERAGE)
8484
endif()
8585

8686
if(_use_onemkl_interfaces)
87-
target_link_libraries(${python_module_name} PUBLIC ${USED_MATH_LIBRARY})
87+
target_link_libraries(${python_module_name} PRIVATE ${MKL_INTERFACES_LIB})
8888
target_compile_options(${python_module_name} PRIVATE -DUSE_ONEMKL_INTERFACES)
8989
if(_use_onemkl_interfaces_cuda)
9090
target_compile_options(${python_module_name} PRIVATE -DUSE_ONEMKL_CUBLAS)

dpnp/backend/extensions/fft/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ if (DPNP_GENERATE_COVERAGE)
8383
endif()
8484

8585
if(_use_onemkl_interfaces)
86-
target_link_libraries(${python_module_name} PUBLIC ${USED_MATH_LIBRARY})
86+
target_link_libraries(${python_module_name} PRIVATE ${MKL_INTERFACES_LIB})
8787
target_compile_options(${python_module_name} PRIVATE -DUSE_ONEMKL_INTERFACES)
8888
else()
8989
target_link_libraries(${python_module_name} PUBLIC MKL::MKL_SYCL::DFT)

dpnp/backend/extensions/lapack/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ if (DPNP_GENERATE_COVERAGE)
101101
endif()
102102

103103
if(_use_onemkl_interfaces)
104-
target_link_libraries(${python_module_name} PUBLIC ${USED_MATH_LIBRARY})
104+
target_link_libraries(${python_module_name} PRIVATE ${MKL_INTERFACES_LIB})
105105
target_compile_options(${python_module_name} PRIVATE -DUSE_ONEMKL_INTERFACES)
106106
else()
107107
target_link_libraries(${python_module_name} PUBLIC MKL::MKL_SYCL::LAPACK)

dpnp/backend/extensions/lapack/getrf.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ static sycl::event getrf_impl(sycl::queue &exec_q,
9696
} catch (mkl_lapack::exception const &e) {
9797
is_exception_caught = true;
9898
info = e.info();
99+
std::cout << "info: " << info << std::endl;
100+
std::cout << e.detail() << std::endl;
99101

100102
if (info < 0) {
101103
error_msg << "Parameter number " << -info

0 commit comments

Comments
 (0)