Remove TODO from the code as no plan to support negative values in shape setter (#2032)

antonwolfy · web-flow · commit d4ee71e52586 · 2024-09-13T17:43:02.000+02:00
diff --git a/dpnp/dpnp_iface_mathematical.py b/dpnp/dpnp_iface_mathematical.py
@@ -224,8 +224,7 @@ def _gradient_num_diff_2nd_order_interior(
         # fix the shape for broadcasting
         shape = [1] * ndim
         shape[axis] = -1
-        # TODO: use shape.setter once dpctl#1699 is resolved
-        # a.shape = b.shape = c.shape = shape
+
         a = a.reshape(shape)
         b = b.reshape(shape)
         c = c.reshape(shape)
diff --git a/tests/third_party/cupy/core_tests/test_ndarray.py b/tests/third_party/cupy/core_tests/test_ndarray.py
@@ -272,7 +272,8 @@ def test_shape_set(self, xp):
         return xp.array(arr.shape)
 
     @pytest.mark.skip(
-        "dpctl-1699: shape setter does not work with negative shape"
+        "dpctl-1699: shape setter does not work with negative shape "
+        "(no plan to support that)"
     )
     @testing.numpy_cupy_array_equal()
     def test_shape_set_infer(self, xp):

Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,8 @@ def test_shape_set(self, xp):`
`272`	`272`	`return xp.array(arr.shape)`
`273`	`273`
`274`	`274`	`@pytest.mark.skip(`
`275`		`- "dpctl-1699: shape setter does not work with negative shape"`
	`275`	`+ "dpctl-1699: shape setter does not work with negative shape "`
	`276`	`+ "(no plan to support that)"`
`276`	`277`	`)`
`277`	`278`	`@testing.numpy_cupy_array_equal()`
`278`	`279`	`def test_shape_set_infer(self, xp):`