Skip to content

Commit d74d96a

Browse files
committed
reviewer's comments
1 parent c75fa5b commit d74d96a

File tree

2 files changed

+103
-4
lines changed

2 files changed

+103
-4
lines changed

dpnp/dpnp_array.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,12 @@ def __radd__(self, other):
247247
# '__rdivmod__',
248248
# '__reduce__',
249249
# '__reduce_ex__',
250-
# '__repr__',
250+
251+
def __repr__(self):
252+
tmp = self._array_obj.__repr__()
253+
tmp = "dpnp_array" + tmp[11:]
254+
return tmp
255+
251256
# '__rfloordiv__',
252257
# '__rlshift__',
253258

@@ -294,9 +299,6 @@ def __str__(self):
294299

295300
return self._array_obj.__str__()
296301

297-
def __repr__(self):
298-
return self._array_obj.__repr__()
299-
300302
def __sub__(self, other):
301303
return dpnp.subtract(self, other)
302304

tests/test_dparray.py

Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,100 @@ def test_flags_strides(dtype, order, strides):
6868
assert usm_array.flags == dpnp_array.flags
6969
assert numpy_array.flags.c_contiguous == dpnp_array.flags.c_contiguous
7070
assert numpy_array.flags.f_contiguous == dpnp_array.flags.f_contiguous
71+
72+
def test_print_dpnp_int():
73+
result = repr(dpnp.array([1, 0, 2, -3, -1, 2, 21, -9], dtype='i4'))
74+
expected = "dpnp_array([ 1, 0, 2, -3, -1, 2, 21, -9], dtype=int32)"
75+
assert(result==expected)
76+
77+
result = str(dpnp.array([1, 0, 2, -3, -1, 2, 21, -9], dtype='i4'))
78+
expected = "[ 1 0 2 -3 -1 2 21 -9]"
79+
assert(result==expected)
80+
# int32
81+
result = repr(dpnp.array([1, -1, 21], dtype=dpnp.int32))
82+
expected = "dpnp_array([ 1, -1, 21], dtype=int32)"
83+
assert(result==expected)
84+
85+
result = str(dpnp.array([1, -1, 21], dtype=dpnp.int32))
86+
expected = "[ 1 -1 21]"
87+
assert(result==expected)
88+
# uint8
89+
result = repr(dpnp.array([1, 0, 3], dtype=numpy.uint8))
90+
expected = "dpnp_array([1, 0, 3], dtype=uint8)"
91+
assert(result==expected)
92+
93+
result = str(dpnp.array([1, 0, 3], dtype=numpy.uint8))
94+
expected = "[1 0 3]"
95+
assert(result==expected)
96+
97+
def test_print_dpnp_float():
98+
result = repr(dpnp.array([1, -1, 21], dtype=float))
99+
expected = "dpnp_array([ 1., -1., 21.])"
100+
assert(result==expected)
101+
102+
result = str(dpnp.array([1, -1, 21], dtype=float))
103+
expected = "[ 1. -1. 21.]"
104+
assert(result==expected)
105+
# float32
106+
result = repr(dpnp.array([1, -1, 21], dtype=dpnp.float32))
107+
expected = "dpnp_array([ 1., -1., 21.], dtype=float32)"
108+
assert(result==expected)
109+
110+
result = str(dpnp.array([1, -1, 21], dtype=dpnp.float32))
111+
expected = "[ 1. -1. 21.]"
112+
assert(result==expected)
113+
114+
def test_print_dpnp_complex():
115+
result = repr(dpnp.array([1, -1, 21], dtype=complex))
116+
expected = "dpnp_array([ 1.+0.j, -1.+0.j, 21.+0.j])"
117+
assert(result==expected)
118+
119+
result = str(dpnp.array([1, -1, 21], dtype=complex))
120+
expected = "[ 1.+0.j -1.+0.j 21.+0.j]"
121+
assert(result==expected)
122+
123+
def test_print_dpnp_boolean():
124+
result = repr(dpnp.array([1, 0, 3], dtype=bool))
125+
expected = "dpnp_array([ True, False, True])"
126+
assert(result==expected)
127+
128+
result = str(dpnp.array([1, 0, 3], dtype=bool))
129+
expected = "[ True False True]"
130+
assert(result==expected)
131+
132+
def test_print_dpnp_special_character():
133+
# NaN
134+
result = repr(dpnp.array([1., 0., dpnp.nan, 3.]))
135+
expected = "dpnp_array([ 1., 0., nan, 3.])"
136+
assert(result==expected)
137+
138+
result = str(dpnp.array([1., 0., dpnp.nan, 3.]))
139+
expected = "[ 1. 0. nan 3.]"
140+
assert(result==expected)
141+
# inf
142+
result = repr(dpnp.array([1., 0., numpy.inf, 3.]))
143+
expected = "dpnp_array([ 1., 0., inf, 3.])"
144+
assert(result==expected)
145+
146+
result = str(dpnp.array([1., 0., numpy.inf, 3.]))
147+
expected = "[ 1. 0. inf 3.]"
148+
assert(result==expected)
149+
150+
def test_print_dpnp_nd():
151+
# 2D
152+
result = repr(dpnp.array([[1, 2], [3, 4]], dtype=float))
153+
expected = "dpnp_array([[1., 2.],\n [3., 4.]])"
154+
assert(result==expected)
155+
156+
result = str(dpnp.array([[1, 2], [3, 4]]))
157+
expected = "[[1 2]\n [3 4]]"
158+
assert(result==expected)
159+
160+
# 0 shape
161+
result = repr(dpnp.empty( shape=(0, 0) ))
162+
expected = "dpnp_array([])"
163+
assert(result==expected)
164+
165+
result = str(dpnp.empty( shape=(0, 0) ))
166+
expected = "[]"
167+
assert(result==expected)

0 commit comments

Comments
 (0)