Backport gh-2202 (#2218)

This PR backports of #2202 from development branch to
`maintenance/0.16.x`.

Author: antonwolfy

CHANGELOG.md

@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.16.1] - 12/XX/2024
+## [0.16.1] - 12/05/2024
 
 This is a bug-fix release.
 
@@ -18,6 +18,7 @@ This is a bug-fix release.
 
 * Resolved an issue with Compute Follows Data inconsistency in `dpnp.extract` function [#2172](https://github.com/IntelPython/dpnp/pull/2172)
 * Resolves an import error when using `dpnp` in virtual environment on Linux [#2199](https://github.com/IntelPython/dpnp/pull/2199)
+* Fixed incorrect result produced by `dpnp.fft.fft` function when input array has negative strides [#2202](https://github.com/IntelPython/dpnp/pull/2202)
 * Resolved a compilation error when building with DPC++ 2025.1 compiler [#2211](https://github.com/IntelPython/dpnp/pull/2211)
 
 ## [0.16.0] - 10/14/2024

dpnp/fft/dpnp_utils_fft.py

@@ -78,11 +78,13 @@ def _commit_descriptor(a, forward, in_place, c2c, a_strides, index, batch_fft):
     shape = a_shape[index:]
     strides = (0,) + a_strides[index:]
     if c2c:  # c2c FFT
+        assert dpnp.issubdtype(a.dtype, dpnp.complexfloating)
         if a.dtype == dpnp.complex64:
             dsc = fi.Complex64Descriptor(shape)
         else:
             dsc = fi.Complex128Descriptor(shape)
     else:  # r2c/c2r FFT
+        assert dpnp.issubdtype(a.dtype, dpnp.inexact)
         if a.dtype in [dpnp.float32, dpnp.complex64]:
             dsc = fi.Real32Descriptor(shape)
         else:
@@ -262,12 +264,14 @@ def _copy_array(x, complex_input):
     in-place FFT can be performed.
     """
     dtype = x.dtype
+    copy_flag = False
     if numpy.min(x.strides) < 0:
         # negative stride is not allowed in OneMKL FFT
         # TODO: support for negative strides will be added in the future
         # versions of OneMKL, see discussion in MKLD-17597
         copy_flag = True
-    elif complex_input and not dpnp.issubdtype(dtype, dpnp.complexfloating):
+
+    if complex_input and not dpnp.issubdtype(dtype, dpnp.complexfloating):
         # c2c/c2r FFT, if input is not complex, convert to complex
         copy_flag = True
         if dtype in [dpnp.float16, dpnp.float32]:
@@ -279,8 +283,6 @@ def _copy_array(x, complex_input):
         # float32 or float64 depending on device capabilities
         copy_flag = True
         dtype = map_dtype_to_device(dpnp.float64, x.sycl_device)
-    else:
-        copy_flag = False
 
     if copy_flag:
         x_copy = dpnp.empty_like(x, dtype=dtype, order="C")

tests/test_fft.py

@@ -379,6 +379,16 @@ def test_fft_validate_out(self):
         out = dpnp.empty((10,), dtype=dpnp.float32)
         assert_raises(TypeError, dpnp.fft.fft, a, out=out)
 
+    @pytest.mark.parametrize(
+        "dtype", get_all_dtypes(no_none=True, no_bool=True)
+    )
+    def test_negative_stride(self, dtype):
+        a = dpnp.arange(10, dtype=dtype)
+        result = dpnp.fft.fft(a[::-1])
+        expected = numpy.fft.fft(a.asnumpy()[::-1])
+
+        assert_dtype_allclose(result, expected, check_only_type_kind=True)
+
 
 class TestFft2:
     def setup_method(self):