Skip to content

Commit f0aa21d

Browse files
authored
Add a missing event dependency for the strided kernel of erf (#2378)
The PR proposes to resolve a sporadic failure due to mismatch with the expected data in `test_strides.py::test_erf`. The issue looks caused by missing dependency from strided erf kernel on a copy event (produced by copy kernel to transfer the strides of input array from host to device memory).
1 parent 74b5e54 commit f0aa21d

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2020

2121
### Fixed
2222

23+
* Resolved an issue with an incorrect result returned due to missing dependency from the strided kernel on a copy event in `dpnp.erf` [#2378](https://github.com/IntelPython/dpnp/pull/2378)
24+
2325

2426
## [0.17.0] - 02/26/2025
2527

dpnp/backend/kernels/dpnp_krnl_elemwise.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ constexpr T dispatch_erf_op(T elem)
148148
} \
149149
}; \
150150
auto kernel_func = [&](sycl::handler &cgh) { \
151+
cgh.depends_on(copy_strides_ev); \
151152
cgh.parallel_for<class __name__##_strides_kernel<_DataType>>( \
152153
gws, kernel_parallel_for_func); \
153154
}; \

0 commit comments

Comments
 (0)