mkl_blas::scal instead of loop in backend rng_rayleigh #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densmirn
approved these changes
Nov 19, 2021
| { | ||
| result1[i] *= scale; | ||
| } | ||
| event_out = mkl_blas::scal(DPNP_QUEUE, size, scale, result1, 1); |
There was a problem hiding this comment.
@LukichevaPolina, please, if it is possible, try to use dependent events everywhere. Something like this:
auto exponential_rng_event = mkl_rng::generate(distribution, DPNP_RNG_ENGINE, size, result1);
auto sqrt_event = mkl_vm::sqrt(DPNP_QUEUE, size, result1, result1, {exponential_rng_event}, mkl_vm::mode::ha);
auto blas_scal_event = mkl_blas::scal(DPNP_QUEUE, size, scale, result1, 1, {sqrt_event});
blas_scal_event.wait();
densmirn
reviewed
Dec 7, 2021
| event_out.wait(); | ||
| auto exponential_rng_event = mkl_rng::generate(distribution, DPNP_RNG_ENGINE, size, result1); | ||
| auto sqrt_event = mkl_vm::sqrt(DPNP_QUEUE, size, result1, result1, {exponential_rng_event}, mkl_vm::mode::ha); | ||
| auto blas_event = mkl_blas::scal(DPNP_QUEUE, size, scale, result1, 1, {sqrt_event}); |
There was a problem hiding this comment.
I would name variable scal_event.
densmirn
approved these changes
Dec 7, 2021
|
@LukichevaPolina Is it possible to exclude data copy in DPNPC_ptr_adapter now? |
Alexander-Makaryev
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.