Skip to content

Leave is_host() call with old compiler only #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2022

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 7, 2022

Since SYCL DPC++ 2023 compiler the function is_host() is deprecated as the host device is no longer supported.
The PR excludes is_host() call from the code when the new compiler is used, i.e. when __SYCL_COMPILER_VERSION < 20221102L.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 7, 2022
@antonwolfy antonwolfy force-pushed the fix_is_host_deprecation branch from 48e8fea to 6ee5bef Compare November 7, 2022 23:39
@antonwolfy antonwolfy force-pushed the fix_is_host_deprecation branch from 1f19bbd to 4030515 Compare November 9, 2022 09:31
@oleksandr-pavlyk
Copy link
Contributor

Related change in dpctl: IntelPython/dpctl#987

@antonwolfy antonwolfy merged commit 33e0da5 into IntelPython:master Nov 11, 2022
@antonwolfy antonwolfy deleted the fix_is_host_deprecation branch November 11, 2022 11:44
xaleryb pushed a commit that referenced this pull request Nov 11, 2022
* Decrease array size for stability (#1227)

* dpnp_array must expose usm_type (#1228)

* Leave is_host() call with old compiler only (#1224)

* Leave is_host() call with old compiler only

* Incremented 2023-SWITCHOVER timestamp

* Exclude running upload steps for fork repo (#1230)

* Setting version to 0.11.0 (#1231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants