-
Notifications
You must be signed in to change notification settings - Fork 22
Beta10 build #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Beta10 build #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
- Coverage 51.45% 0.00% -51.46%
==========================================
Files 19 19
Lines 1240 1240
Branches 329 329
==========================================
- Hits 638 0 -638
- Misses 340 1240 +900
+ Partials 262 0 -262
Continue to review full report at Codecov.
|
antonwolfy
added a commit
that referenced
this pull request
Feb 18, 2025
There is currently no way to install dpnp with any numpy version > 2.0, because - there is no such version available on `https://software.repos.intel.com/python/conda/` channel - numpy from `conda-forge` channel depends on BLAS libraries which has a runtime dependency `mkl < 2025.0` (since BLAS packages with build number 29) There is draft PR ([gh-128](conda-forge/blas-feedstock#128)) to build BLAS with MKL version 2025.0, but it is blocked due to MKL issue ([gh-83](conda-forge/intel_repack-feedstock#83)). Meanwhile there was conda-forge patch ([gh-959](conda-forge/conda-forge-repodata-patches-feedstock#959)) merged recently to add `mkl < 2025.0` constraint to already published BLAS packaged on `conda-forge` with older build number. DPNP package can't fulfill the requirement `mkl < 2025.0`, because it would mandate dpnp build pinning with DPC++ compiler 2024.2. While there were non-backward compatible changes between 2024.2 and 2025.x versions, that is dpnp built with 2024.2 compiler can not be installed with any DPC++ RT 2025.x version, but it is required since targeted by the upcoming release. Thus the PR proposes to temporary disable or workaround all scenario where it is need to tests with numpy from `conda-forge` channel, including tests workflows for python 3.13 (per PR trigger and nightly) and workflow for testing of oneMath interfaces with the latest numpy. The changes has to be rolled back once the above issues are resolved.
github-actions bot
added a commit
that referenced
this pull request
Feb 18, 2025
There is currently no way to install dpnp with any numpy version > 2.0, because - there is no such version available on `https://software.repos.intel.com/python/conda/` channel - numpy from `conda-forge` channel depends on BLAS libraries which has a runtime dependency `mkl < 2025.0` (since BLAS packages with build number 29) There is draft PR ([gh-128](conda-forge/blas-feedstock#128)) to build BLAS with MKL version 2025.0, but it is blocked due to MKL issue ([gh-83](conda-forge/intel_repack-feedstock#83)). Meanwhile there was conda-forge patch ([gh-959](conda-forge/conda-forge-repodata-patches-feedstock#959)) merged recently to add `mkl < 2025.0` constraint to already published BLAS packaged on `conda-forge` with older build number. DPNP package can't fulfill the requirement `mkl < 2025.0`, because it would mandate dpnp build pinning with DPC++ compiler 2024.2. While there were non-backward compatible changes between 2024.2 and 2025.x versions, that is dpnp built with 2024.2 compiler can not be installed with any DPC++ RT 2025.x version, but it is required since targeted by the upcoming release. Thus the PR proposes to temporary disable or workaround all scenario where it is need to tests with numpy from `conda-forge` channel, including tests workflows for python 3.13 (per PR trigger and nightly) and workflow for testing of oneMath interfaces with the latest numpy. The changes has to be rolled back once the above issues are resolved. b09533e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.