Skip to content

Fix abs #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Fix abs #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa1a9ea
add change absolute
Rubtsowa Oct 12, 2020
753d8df
merge
Rubtsowa Oct 12, 2020
ee4bbf0
delete not needed str
Rubtsowa Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dpnp/backend/backend_iface.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,14 @@ INP_DLLEXPORT void
*
* @param [in] array1_in Input array.
*
* @param [in] input_shape Input shape.
*
* @param [out] result1 Output array.
*
* @param [in] size Number of elements in input arrays.
*
*/
template <typename _DataType>
INP_DLLEXPORT void
custom_elemwise_absolute_c(void* array1_in, const std::vector<long>& input_shape, void* result1, size_t size);
custom_elemwise_absolute_c(void* array1_in, void* result1, size_t size);

/**
* @ingroup BACKEND_API
Expand Down
21 changes: 7 additions & 14 deletions dpnp/backend/custom_kernels_mathematical.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ template <typename _KernelNameSpecialization>
class custom_elemwise_absolute_c_kernel;

template <typename _DataType>
void custom_elemwise_absolute_c(void* array1_in, const std::vector<long>& input_shape, void* result1, size_t size)
void custom_elemwise_absolute_c(void* array1_in, void* result1, size_t size)
{
if (!size)
{
Expand All @@ -46,10 +46,6 @@ void custom_elemwise_absolute_c(void* array1_in, const std::vector<long>& input_
_DataType* array1 = reinterpret_cast<_DataType*>(array1_in);
_DataType* result = reinterpret_cast<_DataType*>(result1);

const size_t input_shape_size = input_shape.size();
size_t* input_offset_shape = reinterpret_cast<size_t*>(dpnp_memory_alloc_c(input_shape_size * sizeof(long)));
size_t* result_offset_shape = reinterpret_cast<size_t*>(dpnp_memory_alloc_c(input_shape_size * sizeof(long)));

if constexpr (std::is_same<_DataType, double>::value || std::is_same<_DataType, float>::value)
{
// https://docs.oneapi.com/versions/latest/onemkl/abs.html
Expand Down Expand Up @@ -79,20 +75,17 @@ void custom_elemwise_absolute_c(void* array1_in, const std::vector<long>& input_
}

event.wait();

free(input_offset_shape, DPNP_QUEUE);
free(result_offset_shape, DPNP_QUEUE);
}

template void custom_elemwise_absolute_c<double>(void* array1_in,
const std::vector<long>& input_shape,
void* result1,
size_t size);
template void custom_elemwise_absolute_c<float>(void* array1_in,
const std::vector<long>& input_shape,
void* result1,
size_t size);
template void
custom_elemwise_absolute_c<long>(void* array1_in, const std::vector<long>& input_shape, void* result1, size_t size);
template void
custom_elemwise_absolute_c<int>(void* array1_in, const std::vector<long>& input_shape, void* result1, size_t size);
template void custom_elemwise_absolute_c<long>(void* array1_in,
void* result1,
size_t size);
template void custom_elemwise_absolute_c<int>(void* array1_in,
void* result1,
size_t size);
5 changes: 2 additions & 3 deletions dpnp/backend_mathematical.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ __all__ += [
]


ctypedef void(*fptr_custom_elemwise_absolute_1in_1out_t)(void * , dparray_shape_type & ,
void * , size_t)
ctypedef void(*fptr_custom_elemwise_absolute_1in_1out_t)(void * , void * , size_t)


cpdef dparray dpnp_absolute(dparray input):
Expand All @@ -83,7 +82,7 @@ cpdef dparray dpnp_absolute(dparray input):

cdef fptr_custom_elemwise_absolute_1in_1out_t func = <fptr_custom_elemwise_absolute_1in_1out_t > kernel_data.ptr
# call FPTR function
func(input.get_data(), input_shape, result.get_data(), input.size)
func(input.get_data(), result.get_data(), input.size)

return result

Expand Down