Skip to content

Skip tests which are currently not working on GPU without fp64 aspect #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2023
Merged

Skip tests which are currently not working on GPU without fp64 aspect #1521

merged 3 commits into from
Aug 16, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 16, 2023 •
edited
Loading

The PR indented to temporary skip tests which are not working on a GPU device without fp64 support.
The change unblocks dpnp testing on the GPU with no fp64.

All the skipped tests are placed in separate skipped_tests_gpu_no_fp64.tbl file which is considered an addition to the already existing skipped_tests_gpu.tbl.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy changed the title Skipp tests which are currently not working on GPU without fp64 aspect Skip tests which are currently not working on GPU without fp64 aspect Aug 16, 2023
@antonwolfy antonwolfy merged commit 8ace62f into master Aug 16, 2023
@antonwolfy antonwolfy deleted the skip_no_fp64 branch August 16, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev