Skip to content

Refactor MKL and oneDPL find package and add MKL_VERSION_2024 variable #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 22, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR includes refactoring of MKL and oneDPL find_package logic and using MKL_VERSION_2024 variable to target linking in CMakeLists files.
It updates the logic to provide build compatibility with versions 2024.0.0 and 2023.2.0 for external and internal CI

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev . Nice solution

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I spoke too soon.

The find_package(MKL QUIET) would succeed even for MKL 2023.2. We need a different check to verify if it is MKL_2024.

Can we check directly whether MKL::MKL_SYCL::LAPACK is defined?

@vlad-perevezentsev
Copy link
Collaborator Author

vlad-perevezentsev commented Sep 21, 2023

@oleksandr-pavlyk
I overlooked the fact that MKL_FOUND is true for any MKL version
I added an additional check if(MKL_VERSION GREATER_EQUAL 2024.0.0) inside IF(MKL_FOUND) to identify the new version accurately and the same for oneDPL_FOUND

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants