-
Notifications
You must be signed in to change notification settings - Fork 22
Refactor MKL and oneDPL find package and add MKL_VERSION_2024 variable #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vlad-perevezentsev . Nice solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I spoke too soon.
The find_package(MKL QUIET)
would succeed even for MKL 2023.2. We need a different check to verify if it is MKL_2024.
Can we check directly whether MKL::MKL_SYCL::LAPACK
is defined?
@oleksandr-pavlyk |
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vlad-perevezentsev
This PR includes refactoring of
MKL
andoneDPL
find_package logic and usingMKL_VERSION_2024
variable to target linking inCMakeLists
files.It updates the logic to provide build compatibility with versions
2024.0.0
and2023.2.0
for external and internal CI