Skip to content

update compiler flag #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2024
Merged

update compiler flag #1661

merged 4 commits into from
Apr 8, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 17, 2024

In this PR, deprecated option -fsycl-link-huge-device-code is replaced by -flink-huge-device-code following llvm/sycl release notes for Oct'23 to get rid of warnings generated during build process.
The new option is identical in functionality but allowed with -fopenmp-targets.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jan 17, 2024
Copy link
Contributor

github-actions bot commented Jan 17, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana vtavana marked this pull request as draft January 17, 2024 20:35
@vtavana vtavana marked this pull request as ready for review April 8, 2024 17:11
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for handling that. The warning is gone now.

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for taking the time to fix it
Now the log build looks clean

@vlad-perevezentsev vlad-perevezentsev merged commit 6f056ca into master Apr 8, 2024
@vlad-perevezentsev vlad-perevezentsev deleted the eliminate_compiler_warning branch April 8, 2024 19:11
github-actions bot added a commit that referenced this pull request Apr 8, 2024
- Use `-flink-huge-device-code` instead of `-fsycl-link-huge-device-code` 6f056ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants