Skip to content

Add a retry for running tests in Conda package action #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Add a retry for running tests in Conda package action #1745

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f4c049
Add a retry for running tests in Conda package GitHub action
antonwolfy Mar 13, 2024
59288ad
Merge branch 'master' into retry-on-failure-conda-package-action
antonwolfy Mar 13, 2024
480648d
Corrected shell option of retry action
antonwolfy Mar 13, 2024
82091c2
Single line retry command on Win
antonwolfy Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 39 additions & 10 deletions .github/workflows/conda-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ env:
CHANNELS: '-c dppy/label/dev -c intel -c conda-forge --override-channels'
CONDA_BUILD_VERSION: '24.1.2'
CONDA_INDEX_VERSION: '0.4.0'
TEST_ENV_NAME: 'test'
# TODO: to add test_arraymanipulation.py back to the scope once crash on Windows is gone
TEST_SCOPE: >-
test_arraycreation.py
Expand Down Expand Up @@ -171,10 +172,10 @@ jobs:
auto-update-conda: true
python-version: ${{ matrix.python }}
miniconda-version: 'latest'
activate-environment: 'test'
activate-environment: ${{ env.TEST_ENV_NAME }}

- name: Install conda-index
run: conda install conda-index=${{ env.CONDA_INDEX_VERSION}}
run: conda install conda-index=${{ env.CONDA_INDEX_VERSION }}

- name: Create conda channel
run: |
Expand Down Expand Up @@ -223,10 +224,25 @@ jobs:
python -c "import dpnp; print(dpnp.__version__)"

# TODO: run the whole scope once the issues on CPU are resolved
# - name: Run tests
# run: |
# python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}
# working-directory: ${{ env.tests-path }}

# TODO: remove once 2024.2 release is published
- name: Run tests
run: |
python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}
working-directory: ${{ env.tests-path }}
id: run_tests_linux
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e # v3.0.0
with:
shell: bash
timeout_minutes: 10
max_attempts: 5
retry_on: any
command: |
. $CONDA/etc/profile.d/conda.sh
conda activate ${{ env.TEST_ENV_NAME }}
cd ${{ env.tests-path }}
python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}

test_windows:
name: Test ['windows-latest', python='${{ matrix.python }}']
Expand All @@ -252,7 +268,6 @@ jobs:
extracted-pkg-path: '${{ github.workspace }}\pkg'
tests-path: '${{ github.workspace }}\pkg\info\test\tests\'
ver-json-path: '${{ github.workspace }}\version.json'
active-env-name: 'test'

steps:
- name: Download artifact
Expand Down Expand Up @@ -281,7 +296,7 @@ jobs:
auto-update-conda: true
python-version: ${{ matrix.python }}
miniconda-version: 'latest'
activate-environment: ${{ env.active-env-name }}
activate-environment: ${{ env.TEST_ENV_NAME }}

- name: Store conda paths as envs
run: |
Expand Down Expand Up @@ -362,10 +377,24 @@ jobs:
python -c "import dpnp; print(dpnp.__version__)"

# TODO: run the whole scope once the issues on CPU are resolved
# - name: Run tests
# run: |
# python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}
# working-directory: ${{ env.tests-path }}

# TODO: remove once 2024.2 release is published
- name: Run tests
run: |
python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}
working-directory: ${{ env.tests-path }}
id: run_tests_win
uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e # v3.0.0
with:
shell: cmd
timeout_minutes: 15
max_attempts: 5
retry_on: any
command: >-
conda activate ${{ env.TEST_ENV_NAME }}
& cd ${{ env.tests-path }}
& python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}

upload:
name: Upload ['${{ matrix.os }}', python='${{ matrix.python }}']
Expand Down