Skip to content

Using sphinxcontrib.spelling as extension #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 29, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 23, 2024

The PR enables sphinx extension for spelling checks of the generated documentation.
The spelling check is added to a separated step Run a spelling checker for docs for the appropriate GH action where the documentation is generating.
All detected warnings are resolved or the default spelling dictionary is expanded with new known words.

Note, a manual check that no further warnings are entered is expected by every next PR.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 23, 2024
@antonwolfy antonwolfy force-pushed the add-sphinxcontrib.spelling-as-extension branch from a3beac3 to 1edaf7c Compare April 23, 2024 14:28
Copy link
Contributor

github-actions bot commented Apr 23, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the add-sphinxcontrib.spelling-as-extension branch from 632083d to 12df230 Compare April 26, 2024 10:54
@antonwolfy antonwolfy marked this pull request as ready for review April 26, 2024 11:42
@vlad-perevezentsev
Copy link
Collaborator

As I see you have fixed spelling issues in previous commits
Ignoring ModuleNotFoundError warnings, should we fix another kind of warning like 1127, 1822 and 2495-2748 ?

@antonwolfy
Copy link
Contributor Author

antonwolfy commented Apr 29, 2024

As I see you have fixed spelling issues in previous commits Ignoring ModuleNotFoundError warnings, should we fix another kind of warning like 1127, 1822 and 2495-2748 ?

It will be definitely a part of another PR.

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolf for adding this

@antonwolfy antonwolfy merged commit c348bf4 into master Apr 29, 2024
@antonwolfy antonwolfy deleted the add-sphinxcontrib.spelling-as-extension branch April 29, 2024 15:33
github-actions bot added a commit that referenced this pull request Apr 29, 2024
* Using sphinxcontrib.spelling as extension

* Installing enchant package required by sphinxcontrib-spelling

* Run a spelling checker for docs

* Installing pyenchant package

* Aligned docstrings of elementwise functions with dpctl.tensor

* Aligned docstrings of returns in elementwise functions with dpctl.tensor

* Install enchant apt package

* Extend dictionary with dpnp, dtype, ndarray, ufunc and ufuncs words

* Fixed spelling issues and added 15 new words to known list

* Fixed spelling issues and added 7 new words to known list

* Fixed spelling issues and added 15 new words to known list

* Fixed spelling issues and added 10 new words to known list

* Fixed spelling issues and added 4 new words to known list

* Fixed spelling issues and added 7 new words to known list

* Added missing docstrings to ndarray methods

* Fixed building issue in ndarray.rst

* Resolved a warning: term not in glossary: 'universal function'

* Resolve a warning after rebase with master c348bf4
@vtavana vtavana mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants