Skip to content

Remove Python 3.8 from list of Programming Languages #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 24, 2024

The PR removes Python 3.8 as a Programming Language from the meta data, because dpnp package for python 3.8 will no longer be provided.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 24, 2024
Copy link
Contributor

github-actions bot commented May 24, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vlad-perevezentsev
Copy link
Collaborator

I think it would be a good idea to add a check for python version requirement in setup.
@antonwolfy what do you think?

@antonwolfy
Copy link
Contributor Author

I think it would be a good idea to add a check for python version requirement in setup. @antonwolfy what do you think?

Yes, we can think about that. But it's definitely out of the scope for that PR.

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 108cdfa into maintenance/0.15.x May 24, 2024
40 of 56 checks passed
@antonwolfy antonwolfy deleted the remove-py3_8-from-language-list branch May 24, 2024 16:08
github-actions bot added a commit that referenced this pull request Sep 16, 2024
github-actions bot added a commit that referenced this pull request Sep 16, 2024
vtavana added a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants