Skip to content

Remove leftovers and workarounds where possible #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 17, 2024
Merged

Remove leftovers and workarounds where possible #1931

merged 10 commits into from
Jul 17, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 16, 2024 •
edited
Loading

The PR proposes:

  • to disable rerun tests in Conda package GitHub action by setting environment variable RERUN_TESTS_ON_FAILURE to false inside the action
  • to set dpctl version in host and run dependencies to >=0.18.0*
  • to set DPC++ and MKL version in build and run dependencies to >=2024.2
  • to unmute tests which were previously disable until MKL or DPC++ fixes are available

As a positive effect, the enabled tests help to improve the code coverage significantly.

Note, fewdpnp.linalg.svd tests are kept to be muted due to observing hangs on Windows.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review July 17, 2024 08:13
vtavana
vtavana approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 87cdaff into master Jul 17, 2024
39 of 45 checks passed
@antonwolfy antonwolfy deleted the remove-leftovers branch July 17, 2024 18:50
github-actions bot added a commit that referenced this pull request Jul 17, 2024
@github-actions
Remove leftovers and workarounds where possible (#1931)
713f8ea 
* Make tests rerun conditional

* Bump build and host dependencies in meta.yaml

* Unmuted tests where fixes are expected to be available

* Correct dpctl pinning

* Mute test with dpnp.linalg.svd() hanging on Windows

* Mute one more test relating to dpnp.linalg.svd()

* Mute test_svd_rank4 test relating to dpnp.linalg.svd()

* Mute test_svd_rank4_loop test relating to dpnp.linalg.svd() 87cdaff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana