Skip to content

Revert gh-2082 with w/a for gemm issue in OneMKL #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2024
Merged

Revert gh-2082 with w/a for gemm issue in OneMKL #2101

merged 4 commits into from
Oct 14, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 11, 2024 •
edited
Loading

The issue has been resolved by OneMKL team in scope of 2025.0 release. Thus the PR proposes to remove the workaround #gh-2082 from dpnp code.
While the testing is extended to cover the issue explicitly with matmul function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review October 14, 2024 11:42
vlad-perevezentsev
vlad-perevezentsev approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit dd908f7 into master Oct 14, 2024
46 checks passed
@antonwolfy antonwolfy deleted the revert-gh-2082 branch October 14, 2024 13:16
antonwolfy added a commit that referenced this pull request Oct 14, 2024
@antonwolfy
Revert gh-2082 with w/a for gemm issue in OneMKL (#2101)
123509f 
* Revert "Implement a workaround to gemm issue in OneMKL (#2082)"

This reverts commit 178342c.

* Add test to explicitly cover the w/a for gemm and gemm_batch

* Update test to reproduce the exact issue
@antonwolfy antonwolfy mentioned this pull request Oct 14, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Oct 14, 2024
@github-actions
Revert gh-2082 with w/a for gemm issue in OneMKL (#2101)
d9c0ce4 
* Revert "Implement a workaround to gemm issue in OneMKL (#2082)"

This reverts commit 178342c.

* Add test to explicitly cover the w/a for gemm and gemm_batch

* Update test to reproduce the exact issue dd908f7
github-actions bot added a commit that referenced this pull request Oct 14, 2024
@github-actions
Backport gh-2101 d7e521f
b3c2e7b
antonwolfy added a commit that referenced this pull request Oct 14, 2024
@antonwolfy
Backport gh-2101 (#2108)
cc58db0 
* Revert gh-2082 with w/a for gemm issue in OneMKL (#2101)

* Revert "Implement a workaround to gemm issue in OneMKL (#2082)"

This reverts commit 178342c.

* Add test to explicitly cover the w/a for gemm and gemm_batch

* Update test to reproduce the exact issue

* Set release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev