Skip to content

Backport gh-2209 #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Backport gh-2209 #2220

merged 3 commits into from
Dec 6, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 6, 2024

This PR backports of #2209 from development branch to maintenance/0.16.x.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

antonwolfy and others added 2 commits December 6, 2024 11:36
The PR proposes to move `dpnp.from_dlpack` function to
`dpnp/dpnp_iface_arraycreation.py` and to update docstring description,
because there were formatting issues within rendered documentation of
`dpnp.from_dlpack`.

Also sphinx configuration was tuned to add mapping towards dpctl
documentation pages.
Copy link
Contributor

github-actions bot commented Dec 6, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Co-authored-by: vlad-perevezentsev <[email protected]>
@vlad-perevezentsev vlad-perevezentsev self-requested a review December 6, 2024 11:58
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 67e620a into maintenance/0.16.x Dec 6, 2024
11 checks passed
@antonwolfy antonwolfy deleted the backport-gh-2209 branch December 6, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants