Skip to content

Resolve issues in public CI (part #2) #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2025
Merged

Resolve issues in public CI (part #2) #2257

merged 4 commits into from
Jan 13, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 13, 2025 •
edited
Loading

The PR proposes to add fixes/improvements into the public CI:

  • trigger resetup miniconda step on failure in building docs and coverage workflows
  • trigger resetup miniconda & reinstall dpnp steps in case of failure within test_linux job of conda package workflow

Note, the PR continues work initiated in #2254 and indented to make public CI more stable.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 65.094%. remained the same
when pulling adb04c0 on stabilize-public-ci-part-2
into 3d02b6b on master.

@antonwolfy antonwolfy marked this pull request as ready for review January 13, 2025 15:23
vlad-perevezentsev
vlad-perevezentsev approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you @antonwolfy for stabilizing the public CI

@antonwolfy antonwolfy merged commit 9d445ba into master Jan 13, 2025
57 of 58 checks passed
@antonwolfy antonwolfy deleted the stabilize-public-ci-part-2 branch January 13, 2025 15:57
github-actions bot added a commit that referenced this pull request Jan 13, 2025
@github-actions
Resolve issues in public CI (part #2) (#2257)
44642d2 
The PR proposes to add fixes/improvements into the public CI:
- trigger resetup miniconda step on failure in building docs and
coverage workflows
- trigger resetup miniconda & reinstall dpnp steps in case of failure
within `test_linux` job of conda package workflow

Note, the PR continues work initiated in #2254 and indented to make
public CI more stable. 9d445ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vlad-perevezentsev