Skip to content

fix issue gh-2264 #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix issue gh-2264 #2278

merged 3 commits into from
Jan 29, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 24, 2025

resolves gh-2264

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jan 24, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2025 •
edited
Loading

Coverage Status

coverage: 71.325% (+0.009%) from 71.316%
when pulling c985d73 on fix_gh-2264
into 91161a8 on master.

@vtavana vtavana marked this pull request as ready for review January 24, 2025 16:28
antonwolfy
antonwolfy approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_5 ran successfully.
Passed: 958
Failed: 0
Skipped: 42

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_13 ran successfully.
Passed: 968
Failed: 0
Skipped: 32

@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2278/index.html

@vtavana vtavana merged commit 0e479cc into master Jan 29, 2025
59 of 70 checks passed
@vtavana vtavana deleted the fix_gh-2264 branch January 29, 2025 03:24
github-actions bot added a commit that referenced this pull request Jan 29, 2025
@github-actions
fix issue gh-2264 (#2278)
97f3e72 
resolves gh-2264 0e479cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

matmul raises IndexError exception with input shapes (2, 1, 2) and (2,)
3 participants
@vtavana @coveralls @antonwolfy